Issue 40 in omaha: Visual Studio 2010 support (feature request)

[om...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 40 by kobalicek.petr: Visual Studio 2010 support (feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Google omaha can't be build with newest Visual Studio 2010. The biggest
problem is that it can be even build if Visual Studio 2005/2008 is
installed together with Visual Studio 2010 (There is some autodetection
which always prefers to use VS 2010)

I did several experiments to build this software using Visual Studio 2010,
but I always failed, although I solved some things.

So, is VS 2010/2012 support planned in the future? When it's expected to be
done?

Thanks!

[om...@googlecode.com]

Updates:
Status: WontFix

Comment #1 on issue 40 by ryan...@google.com: Visual Studio 2010 support
(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Open omaha\third_party\smartany\smart_any_fwd.h and replace all appearances
of "static_assert" with some other string, such as "my_static_assert" --
this should allow you to build with VS2010.

The problem is that VC2010 included partial support for C++11; in that
version of the language, static_assert becomes a language keyword. There's
no way to disable this support in 2010, so you'll have to modify that
code. We'll make this change ourselves in the official sources shortly.

Feel free to change the Status of the bug back to Open if this doesn't work
for you. :)

[om...@googlecode.com]

Comment #2 on issue 40 by kobalicek.petr: Visual Studio 2010 support
(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Hi,

changing static_assert is not enough to successfully compile omaha.
Yesterday I finished with changes to make compilation under Visual Studio
2010 possible and there were more things to change, but it compiled and all
unit tests passed.

I will send patches when we are done.

[om...@googlecode.com]

Comment #3 on issue 40 by kobalicek.petr: Visual Studio 2010 support
(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Hi Ryan,

following patch can be used to make compilation under Visual Studio 2010
possible. Gtest and gmock libraries under third_party have to be updated to
newer versions to be successful.

Apply to omaha/base.

Please review the patch and tell me if you have any questions.

Thanks!

Attachments:
vs2010_base.patch 2.3 KB

[om...@googlecode.com]

Comment #4 on issue 40 by nick.cha...@nichesolutions.co.uk: Visual Studio

2010 support (feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Hi Petr,

I have applied your patch, and updated gtest and gmock to the latest
versions (1.6.0), but am still unable to build using VS 2010.

I see the following errors:

________Compiling scons-out\dbg-win\obj\mi_exe_stub\mi_mi.obj
mi.cc
c:\Program Files (x86)\Microsoft Visual Studio
10.0\VC\ATLMFC\INCLUDE\atlalloc.h
(493) : error C2220: warning treated as error - no 'object' file generated
.........
c:\Program Files (x86)\Microsoft Visual Studio
10.0\VC\ATLMFC\INCLUDE\atlcomcli.
h(1751) : error C2338: CVarTypeInfo< char > cannot be compiled with /J or
_CHAR_
UNSIGNED flag enabled
c:\Program Files (x86)\Microsoft Visual Studio
10.0\VC\ATLMFC\INCLUDE\atlcomcli.
h(1774) : error C2338: CVarTypeInfo< char* > cannot be compiled with /J or
_CHAR
_UNSIGNED flag enabled

I also get a whole load of warnings about "nonstandard extension used:
throw (...)"

Just wondering if you saw these issues previously, and did something else
to fix?

Thanks for your efforts so far - there are not enough people sharing the
knowledge on Omaha!

[om...@googlecode.com]

Comment #5 on issue 40 by kobalicek.petr: Visual Studio 2010 support
(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Hi, I think that you can solve this by doing following:

1. Edit main.scons CPPPATH variable and add somewhere path where is ATL,
not that ATL from Visual Studio 2010, omaha requires atlserver or how is
that called:

# Where to look for include files.
CPPPATH = [
'$MAIN_DIR',
'$MAIN_DIR/..',
'$MAIN_DIR/../thirdparty/atlmfc/include',
'$MAIN_DIR/third_party/chrome',
'$MAIN_DIR/third_party/gtest/include',
],

2. Turn warnings off

'/wd4986', # Exception specification does not match previous
declaration.
'/wd4987', # Nonstandard extension used: 'throw (...)'

3. Disable "warnings as errors"

# '/WX', # warnings as errors

Hope that helps :)

[om...@googlecode.com]

Comment #6 on issue 40 by nick.cha...@nichesolutions.co.uk: Visual Studio

2010 support (feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Thanks, Petr. Worked perfectly! :)

[om...@googlecode.com]

Comment #7 on issue 40 by kobalicek.petr: Visual Studio 2010 support
(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Why is this WontFix? Community did it, why it can't be official?

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[om...@googlecode.com]

Updates:
Status: Accepted

Comment #8 on issue 40 by so...@google.com: Visual Studio 2010 support
(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Reopened the bug.

[om...@googlecode.com]

Comment #9 on issue 40 by mmange...@gmail.com: Visual Studio 2010 support
(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Can Omaha work fine with vs2010?
I build Omaha with vs2010.
Before I customized it, I use google product to test it.
After downloading completes, Omaha crashes.

[om...@googlecode.com]

Comment #10 on issue 40 by so...@chromium.org: Visual Studio 2010 support
(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

If the code builds with vs2010 I expect it to run ok. Would you be able to
debug, get a stack trace, and see where it crashes?

[om...@googlecode.com]

Comment #11 on issue 40 by batterma...@163.com: Visual Studio 2010 support
(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

i do as above, and i received bug report as below

scons: Reading SConscript files ...
Using precompiled headers.
Building versions: 1.3.23.0
python D:\omaha\tools\proxy_clsid_utils.py
scons: done reading SConscript files.
scons: Building targets ...
scons: building associated VariantDir targets: scons-out
________Linking scons-out\dbg-win\obj\goopdate\goopdate_unsigned.dll
Using tempfile c:\users\aser\appdata\local\temp\tmpszwaci.lnk for command
line:
link /nologo /MACHINE:X86 /nologo /SUBSYSTEM:WINDOWS /MACHINE:X86 /RELEASE
/MAP /NODEFAULTLIB /DYNAMICBASE /NXCOMPAT /SAFESEH /DEBUG
/DELAYLOAD:oleaut32.dll /DELAYLOAD:psapi.dll /DELAYLOAD:rasapi32.dll
/DELAYLOAD:shell32.dll /DELAYLOAD:shlwapi.dll /DELAYLOAD:userenv.dll
/DELAYLOAD:version.dll /DELAYLOAD:wtsapi32.dll /INCLUDE:_WSAStartup@8
/BASE:0x18000000 /dll /nologo /SUBSYSTEM:WINDOWS /MACHINE:x86
/out:scons-out\dbg-win\obj\goopdate\goopdate_unsigned.dll
/implib:scons-out\dbg-win\obj\goopdate\goopdate_unsigned.lib
/LIBPATH:scons-out\dbg-win\lib advapi32.lib comdlg32.lib gdi32.lib
kernel32.lib odbc32.lib odbccp32.lib ole32.lib oleaut32.lib shell32.lib
user32.lib uuid.lib winspool.lib D:\omaha\scons-out\dbg-win/lib/base.lib
D:\omaha\scons-out\dbg-win/lib/breakpad.lib
D:\omaha\scons-out\dbg-win/lib/client.lib
D:\omaha\scons-out\dbg-win/lib/common.lib
D:\omaha\scons-out\dbg-win/lib/core.lib
D:\omaha\scons-out\dbg-win/lib/google_update_recovery.lib
D:\omaha\scons-out\dbg-win/lib/goopdate_lib.lib
D:\omaha\scons-out\dbg-win/lib/logging.lib
D:\omaha\scons-out\dbg-win/lib/net.lib
D:\omaha\scons-out\dbg-win/lib/omaha3_idl.lib
D:\omaha\scons-out\dbg-win/lib/security.lib
D:\omaha\scons-out\dbg-win/lib/service.lib
D:\omaha\scons-out\dbg-win/lib/setup.lib
D:\omaha\scons-out\dbg-win/lib/statsreport.lib
D:\omaha\scons-out\dbg-win/lib/ui.lib atlsd.lib libcmtd.lib libcpmtd.lib
bits.lib comctl32.lib crypt32.lib delayimp.lib iphlpapi.lib msi.lib
msimg32.lib mstask.lib netapi32.lib psapi.lib rasapi32.lib rpcns4.lib
rpcrt4.lib shlwapi.lib taskschd.lib version.lib userenv.lib wininet.lib
wintrust.lib ws2_32.lib wtsapi32.lib
/PDB:scons-out\dbg-win\obj\goopdate\goopdate_unsigned.pdb /DEBUG
/def:goopdate\goopdate.def scons-out\dbg-win\obj\goopdate\main.obj
scons-out\dbg-win\obj\goopdate\goopdate.res
scons-out\dbg-win\obj\goopdate\goopdate_version.res
scons-out\dbg-win\obj\goopdate\goopdate_unsigned_pch.obj
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_am.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_ar.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_bg.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_bn.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_ca.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_cs.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_da.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_de.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_el.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_en.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_en-GB.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_es.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_es-419.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_et.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_fa.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_fi.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_fil.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_fr.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_gu.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_hi.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_hr.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_hu.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_id.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_is.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_it.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_iw.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_ja.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_kn.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_ko.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_lt.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_lv.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_ml.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_mr.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_ms.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_nl.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_no.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_pl.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_pt-BR.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_pt-PT.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_ro.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_ru.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_sk.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_sl.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_sr.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_sv.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_sw.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_ta.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_te.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_th.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_tr.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_uk.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_ur.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_vi.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_zh-CN.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_zh-TW.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_or.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_userdefault.res
scons-out\dbg-win\obj\goopdate\resources\goopdate_dll\generated_resources_zh-HK.res
________Linking
scons-out\dbg-win\obj\plugins\update\npGoogleUpdate3_unsigned.dll
正在创建库 scons-out\dbg-win\obj\goopdate\goopdate_unsigned.lib 和对象
scons-out\dbg-win\obj\goopdate\goopdate_unsigned.exp
base.lib(exception_barrier_lowlevel.obj) : error LNK2001: 无法解析的外部符
号 ExceptionBarrierHandler
scons-out\dbg-win\obj\goopdate\goopdate_unsigned.dll : fatal error LNK1120:
1 个无法解析的外部命令
________Creating library
scons-out\dbg-win\obj\recovery\repair_exe\repair_goopdate.lib
正在创建库
scons-out\dbg-win\obj\plugins\update\npGoogleUpdate3_unsigned.lib 和对象
scons-out\dbg-win\obj\plugins\update\npGoogleUpdate3_unsigned.exp
base.lib(exception_barrier_lowlevel.obj) : error LNK2001: 无法解析的外部符
号 ExceptionBarrierHandler
scons-out\dbg-win\obj\plugins\update\npGoogleUpdate3_unsigned.dll : fatal
error LNK1120: 1 个无法解析的外部命令
________Compiling
scons-out\dbg-win\obj\recovery\repair_exe\custom_action\execute_repair_file.obj
execute_repair_file.cc
scons: building terminated because of errors.

the chinese charaters means can not get the sybol***?

[om...@googlecode.com]

Comment #12 on issue 40 by kohan...@noknok.com: Visual Studio 2010 support
(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Google omaha can't be build also with newest Visual Studio 2012.

[om...@googlecode.com]

Comment #13 on issue 40 by kohan...@noknok.com: Visual Studio 2010 support
(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Omaha will successful build if Visual Studio 2008 is installed together
with Visual Studio 2012.
Result for Omaha build when installed only Visual Studio 2012:
C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\ATLMFC\INCLUDE\atldef.h(76): fatal error C1189: #error : ATL
doesn't support compilation with /J or _CHAR_UNSIGNED flag enabled

[om...@googlecode.com]

Comment #14 on issue 40 by awinashk...@gmail.com: Visual Studio 2010

support (feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Hi,
I have applied patch which include in above comment, and also changed in
main.scons file which suggested by petr, but am still unable to build omaha

using VS 2010.

I see the following errors:

C:\Program Files (x86)\Microsoft Visual Studio

10.0\VC\ATLMFC\INCLUDE\atlcomcli.h(1751) : error C2338: CVarTypeInfo< cha
r > cannot be compiled with /J or _CHAR_UNSIGNED flag enabled

C:\Program Files (x86)\Microsoft Visual Studio

10.0\VC\ATLMFC\INCLUDE\atlcomcli.h(1774) : error C2338: CVarTypeInfo< cha
r* > cannot be compiled with /J or _CHAR_UNSIGNED flag enabled
scons: *** [scons-out\dbg-win\obj\mi_exe_stub\mi_mi.obj] Error 2

scons: building terminated because of errors.

Is it required to update gtest and gmock to the latest versions, if yes how
it is update.

please suggest to me how build it.

Thanks
awinash

[om...@googlecode.com]

Comment #15 on issue 40 by kobalicek.petr: Visual Studio 2010 support
(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Hi Awinash,

my recommendation is not to use Google Omaha. This software has some issues
and there are no fixes; and as I know Google has an improved version that
never went to the public.

If you take the time you will spend by customizing Omaha and fixing all the
bugs & unit tests you should be able to find a better solution (even paid).
If you, by any reason, decide to continue with Omaha, I recommend you to
use Visual Studio 2005 as did by Google.

[om...@googlecode.com]

Comment #16 on issue 40 by kobalicek.petr: Visual Studio 2010 support

(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Hi Awinash,

my recommendation is not to use Google Omaha. This software has some issues
and there are no fixes; and as I know Google has an improved version that
never went to the public.

If you take the time you will spend by customizing Omaha and fixing all the
bugs & unit tests you should be able to find a better solution (even paid).
If you, by any reason, decide to continue with Omaha, I recommend you to

use Visual Studio 2005 as Google did.

[om...@googlecode.com]

Comment #17 on issue 40 by awinashk...@gmail.com: Visual Studio 2010

support (feature request)
http://code.google.com/p/omaha/issues/detail?id=40

Hi petr,

Thanks for your reply.

is chromium 28 support to generate crash report when browser crash. Google
chrome support to generate crash report and it send that report to Google
server.

[om...@googlecode.com]

Comment #18 on issue 40 by g...@crossrider.com: Visual Studio 2010 support
(feature request)
http://code.google.com/p/omaha/issues/detail?id=40

#11 this will solve the issue in VS2012
;IF @version LT 800
_ExceptionBarrierHandler PROTO
.SAFESEH _ExceptionBarrierHandler
;ELSE
;ExceptionBarrierHandler PROTO
;.SAFESEH ExceptionBarrierHandler
;ENDIF

[om...@googlecode.com]

Comment #19 on issue 40 by alberto....@gmail.com: Visual Studio 2010

support (feature request)
http://code.google.com/p/omaha/issues/detail?id=40

hi i have this error
16>C:\Program Files (x86)\Microsoft Visual Studio
10.0\VC\atlmfc\include\atlcomcli.h(1751): error C2338: CVarTypeInfo< char >

cannot be compiled with /J or _CHAR_UNSIGNED flag enabled

can your help me????

[om...@googlecode.com]

Comment #20 on issue 40 by alberto....@gmail.com: Visual Studio 2010

support (feature request)
http://code.google.com/p/omaha/issues/detail?id=40

hi i have this error
16> C: \ Program Files (x86) \ Microsoft Visual Studio 10.0 \ VC \ atlmfc \

include \ atlcomcli.h (1751): error C2338: CVarTypeInfo <char> non può
essere compilato con / J o bandiera _CHAR_UNSIGNED abilitati
can you help me??

[om...@googlecode.com]

Comment #21 on issue 40 by alberto....@gmail.com: Visual Studio 2010

support (feature request)
http://code.google.com/p/omaha/issues/detail?id=40

i have this error
16>C:\Program Files (x86)\Microsoft Visual Studio

10.0\VC\atlmfc\include\atlcomcli.h(1751): error C2338: CVarTypeInfo< char >
cannot be compiled with /J or _CHAR_UNSIGNED flag enabled

can you help me???

[om...@googlecode.com]

Comment #22 on issue 40 by alberto....@gmail.com: Visual Studio 2010

support (feature request)
http://code.google.com/p/omaha/issues/detail?id=40

i install the hotfix in this page that can solve this problem but the error
isn't fixed

[om...@googlecode.com]

Comment #23 on issue 40 by alberto....@gmail.com: Visual Studio 2010

support (feature request)
http://code.google.com/p/omaha/issues/detail?id=40

http://connect.microsoft.com/VisualStudio/Downloads/DownloadDetails.aspx?DownloadID=33885

[om...@googlecode.com]

Comment #24 on issue 40 by pritesha...@gmail.com: Visual Studio 2010

support (feature request)
http://code.google.com/p/omaha/issues/detail?id=40

kobalicek.petr
could you tell steps to turn off warning?