Drupal filter and sub-filters

[Yves Savourel]

Hi Jim,

Do you see any problem if we add the Drupal filter code to the subfilter branch?

We are at a point where being able to use it from Rainbow would help. That shouldn't bother any sub-filter changes. For now we just hack the sub-filter parts and we'll replace that with the proper calls when it's ready.

-ys

[Jim Hargrave]

You might want to look at the subfilter branch first and see what's
broken. If none of the errors affects your code then it shouldn't be a
problem.

Why not add the filter to master? We can merge it over to subfilter
later. That would give you a stable place to test the filter.

Jim

[Yves Savourel]

> Why not add the filter to master?
> We can merge it over to subfilter later.

I suppose we could do that too. I was thinking we would be able to test/tune-up the sub-fliter better. But you're right: it doesn't matter when we do the switch. And maybe it's simplify things.

-ys

[Jim Hargrave]

Won't you still need to test the filter as a normal filter? I don't know
much about Drupal. I would test normally - then we merge over to
subfilter and start adding ISubFilter implementation.

btw - we are close to our TMS deployment - after that I hope to have
more time to dedicate to this.

Jim

[Yves Savourel]

> Won't you still need to test the filter as
> a normal filter? I don't know much about Drupal.
> I would test normally - then we merge over
> to subfilter and start adding ISubFilter implementation.

Actually in the case of Drupal, I don't think it makes much sense to have it as a sub-filter, but it is definitely using the HTML Filter as a sub-filter.

We'll probably move the code to the master branch today or tomorrow.

-ys

[Jimbo]

Right HTML is out of commission in subfilter I should be able to finish the refactor this week