Proposal to remove xliff compare integration tests ...

5 views
Skip to first unread message

jim

unread,
Nov 5, 2021, 3:42:54 PM11/5/21
to Group: okapi-devel
Since we have agreed that each Okapi release does not have to preserve
backwards compatibility I recommend we delete our xliff comparison
tests. They are a pain to update and I don't think they provide much in
the way of testing. Since the other tests have been beefed up they
should catch any major problems.

Thoughts?

Jim

Chase Tingley

unread,
Nov 6, 2021, 12:52:30 AM11/6/21
to okapi...@googlegroups.com
My main reservation is that they have definitely caught cases where we changed extraction behavior in ways that we didn’t intend to. As much of a nuisance as they are, I do feel like we’ve caught bugs that way. 

--
You received this message because you are subscribed to the Google Groups "okapi-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to okapi-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/okapi-devel/5f4b6981-3596-50e3-1a5d-1d4b7801ded2%40gmail.com.

jim

unread,
Nov 7, 2021, 1:37:05 PM11/7/21
to okapi...@googlegroups.com, Chase Tingley
I wonder if there is an easier way to test this vs having the code run through hundreds of similar files. Maybe we can handcraft one or two uber files per format?

I'm also eager to move away from xliff 1.2 as a pivot format as it won't support everything in xliff 2.0.

Topic for a biweekly meeting discussion.

cheers,

Jim
Reply all
Reply to author
Forward
0 new messages