Okapi broken build...

0 views
Skip to first unread message

Jim Hargrave

unread,
Jun 25, 2025, 1:44:14 PMJun 25
to Group: okapi-devel

I merged Denis PR with the updated XmlUnit comparison code and we now get a number of failures. I will take a look at these. The xml comparison test is very strict (ideally we always want the strictest test possible)

We have a few options:

  1. Fix the filter issue (if indeed there is a bug)
  2. Remove the offending file from testing.
  3. Further refine the XmlUnit comparison code to skip cases we know will be different (preferred option)
  4. We may need to revert some integration comparisons back to standard event compare.


Now that the XMLUnit code is now working and comparing all attributes we are going to see more failures - especially with xliff compare tests. Generally I think this is a good thing, especially before a release.

Jim

Jim Hargrave

unread,
Jun 25, 2025, 1:50:42 PMJun 25
to Group: okapi-devel

Hum, some of the failures are caused by the code id changes. I may need to revert Denis' PR - then update the XmlUnit comparisons and fix problems. Then Denis can resubmit his PR's

That way Denis can focus on the failures directly caused by the PR's code changes.

Jim

Reply all
Reply to author
Forward
0 new messages