How-to examples: orthogonal layout

28 views

Skip to first unread message

Nathan Grinsztajn

unread,

Jan 3, 2022, 10:14:52 AM1/3/22

to ogdf

Hello!

I'm am currently experimenting with the ogdf library, using the "How-to examples" and especially the Orthogonal layout subsection. It appears to me that the variable crossMin which is defined in this example at line 31 is in fact never used to construct the final layout. Is there a missing pl.setCrossMin somewhere? It may be a typo, or maybe I am missing something here!

Thank you in advance!

Nathan Grinsztajn

Dagobert Smart

unread,

Jan 3, 2022, 10:45:06 AM1/3/22

to ogdf

Hello Nathan,

you are completely correct. The pl.setCrossMin(crossMin) is missing (and in order to add it, crossMin should be a pointer anyway).
This addition would not actually change the behavior of the code since the SubgraphPlanarizer with the given options is already the default for the PlanarizationLayout. However, it is definitely confusing.
I will adapt the code for the next release.