Demos not working out of the box due to .rc missing - CMake/Visual Studio

23 views
Skip to first unread message

Vaillancourt

unread,
Jan 16, 2025, 9:44:14 AMJan 16
to ode-users
Hello!

I noticed the demos don't work "out of the box" when producing a Visual Studio solution with CMake; when running a demo, the .rc can't be found and the app "aborts".

I'm not CMake guru but I managed to create a fix for it here:

Not sure if this should be reviewed by "more expert eyes" or if it's good for a pull request to be integrated in master.

Thanks!

Alexandre Vaillancourt

Oleh Derevenko

unread,
Jan 16, 2025, 4:35:06 PMJan 16
to ode-...@googlegroups.com
I'm not an expert in CMake either but this does not look right to me. Resource file is to be linked into the binary, it does not need to be copied into target folder. If a resource file is missing the compilation should fail.

Oleh Derevenko

-- Skype with underscore

 


From: ode-...@googlegroups.com <ode-...@googlegroups.com> on behalf of Vaillancourt <alexandre.vai...@gmail.com>
Sent: Thursday, January 16, 2025 16:44
To: ode-users <ode-...@googlegroups.com>
Subject: [ode-users] Demos not working out of the box due to .rc missing - CMake/Visual Studio
 
--
You received this message because you are subscribed to the Google Groups "ode-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ode-users+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/ode-users/5db07635-fe62-4b7d-9514-a2ec22b22cafn%40googlegroups.com.


This e-mail may contain privileged and confidential information. If you are not the intended recipient, be aware that any use, disclosure, copying or distribution of this e-mail or any attachments is prohibited. If you have received this e-mail in error, please notify us immediately by returning it to the sender and delete this copy from your system. Thank you.

Vaillancourt

unread,
Jan 16, 2025, 4:46:31 PMJan 16
to ode-users
Oleh,

> Resource file is to be linked into the binary

I'm not accustomed to work with these specifically, but this makes some sense. 

> If a resource file is missing the compilation should fail.

It doesn't fail on my end.

I'll see what can be done about this.

Alexandre Vaillancourt

Oleh Derevenko

unread,
Jan 16, 2025, 5:10:17 PMJan 16
to ode-...@googlegroups.com
Resource files are to be added as linker inputs


Oleh Derevenko

-- Skype with underscore

 


Sent: Thursday, January 16, 2025 23:46
To: ode-users <ode-...@googlegroups.com>
Subject: Re: [ode-users] Demos not working out of the box due to .rc missing - CMake/Visual Studio
 

Vaillancourt

unread,
Jan 16, 2025, 5:39:09 PMJan 16
to ode-users
Okay I tested this again.

For some odd reason I don't encounter this issue anymore. 

Issue closed, thanks for your time!

Reply all
Reply to author
Forward
0 new messages