Small Errors Thread

63 views
Skip to first unread message

Adrian Scheffler

unread,
Apr 8, 2014, 4:34:17 AM4/8/14
to obey-the-test...@googlegroups.com
Hi,
http://chimera.labs.oreilly.com/books/1234000000754/ch06.html#_removing_now_redundant_code_and_tests The programlisting is not syntax highlighted as usual.
If i spot more small errors like this, i will post it here so that the group gets not polluted with this unimportant stuff.
Very pleasant reading. Thanks!

Steve Young

unread,
Apr 9, 2014, 6:43:59 PM4/9/14
to obey-the-test...@googlegroups.com
At http://chimera.labs.oreilly.com/books/1234000000754/ch06.html#_implementing_the_new_design_using_tdd, in the code listing for tests.py, the last line has 'satisified' instead of 'satisfied'.  I don't think that is a British spelling?

Steve Young

unread,
Apr 9, 2014, 6:48:10 PM4/9/14
to obey-the-test...@googlegroups.com
And a bit past the above block you have a section starting with 
"I found the FTs hung when I tried to run them today...." and suggest upgrading Selenium.  At the beginning of the book you said to use 2.39 - so this is a bit confusing.  

I am sticking with 2.39 myself. :-)

Steve Young

unread,
Apr 9, 2014, 8:35:59 PM4/9/14
to obey-the-test...@googlegroups.com
At: lists/tests.py (ch06l021-2) in http://chimera.labs.oreilly.com/books/1234000000754/ch06.html#_a_test_class_for_new_list_creation

There seem to be some typos in the code - unless Dan and I are implementing something wrong.  The comments show how I got things working.

Steve Young

unread,
Apr 9, 2014, 10:06:18 PM4/9/14
to obey-the-test...@googlegroups.com
Well, a bit further down the page I had to revert the trailing slashes - another comment is on the page.  Not sure where the mixup was, but probably something I did?

Steve


On Wed, Apr 9, 2014 at 7:35 PM, Steve Young <wereapw...@gmail.com> wrote:
At: lists/tests.py (ch06l021-2) in http://chimera.labs.oreilly.com/books/1234000000754/ch06.html#_a_test_class_for_new_list_creation

There seem to be some typos in the code - unless Dan and I are implementing something wrong.  The comments show how I got things working.

--
You received this message because you are subscribed to the Google Groups "Obey the testing goat! Test-Driven Web Development with Python book" group.
To unsubscribe from this group and stop receiving emails from it, send an email to obey-the-testing-go...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Adrian Scheffler

unread,
Apr 10, 2014, 4:30:50 AM4/10/14
to obey-the-test...@googlegroups.com
http://chimera.labs.oreilly.com/books/1234000000754/ch09.html#_breakdown_of_a_fabric_script_for_our_deployment The "Here's one I made earlier"-Link goes to some unrelated wikipedia page about the content of a television show.

Adrian Scheffler

unread,
Apr 14, 2014, 5:00:50 AM4/14/14
to obey-the-test...@googlegroups.com
http://chimera.labs.oreilly.com/books/1234000000754/ch10.html#_splitting_functional_tests_out_into_many_files " I prefer to use relative imports only when I’m super-super sure that the relative position of source."

Adrian Scheffler

unread,
Apr 14, 2014, 5:05:54 AM4/14/14
to obey-the-test...@googlegroups.com

Harry Percival

unread,
Apr 14, 2014, 1:29:28 PM4/14/14
to Steve Young, obey-the-test...@googlegroups.com
I suspect this was an inconsistency between urls.py and tests.py.   Neither should use trailing slashes for the url /lists/new, but if they differ, you see confusing 301 redirects...
--
------------------------------
Harry J.W. Percival
------------------------------
Twitter: @hjwp
Mobile:  +44 (0) 78877 02511
Skype:         harry.percival

Harry Percival

unread,
Apr 14, 2014, 1:30:53 PM4/14/14
to Adrian Scheffler, obey-the-test...@googlegroups.com
maybe I need to change that link to this one?  http://www.bbc.co.uk/cult/classic/bluepeter/valpetejohn/trivia.shtml


On 10 April 2014 04:30, Adrian Scheffler <adria...@hush.com> wrote:
http://chimera.labs.oreilly.com/books/1234000000754/ch09.html#_breakdown_of_a_fabric_script_for_our_deployment The "Here's one I made earlier"-Link goes to some unrelated wikipedia page about the content of a television show.

--
You received this message because you are subscribed to the Google Groups "Obey the testing goat! Test-Driven Web Development with Python book" group.
To unsubscribe from this group and stop receiving emails from it, send an email to obey-the-testing-go...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Adrian Scheffler

unread,
Apr 14, 2014, 3:11:46 PM4/14/14
to obey-the-test...@googlegroups.com, Adrian Scheffler, hj...@cantab.net
Ah, i get it now :-)


On Monday, April 14, 2014 7:30:53 PM UTC+2, Harry Percival wrote:
maybe I need to change that link to this one?  http://www.bbc.co.uk/cult/classic/bluepeter/valpetejohn/trivia.shtml
On 10 April 2014 04:30, Adrian Scheffler <adria...@hush.com> wrote:
http://chimera.labs.oreilly.com/books/1234000000754/ch09.html#_breakdown_of_a_fabric_script_for_our_deployment The "Here's one I made earlier"-Link goes to some unrelated wikipedia page about the content of a television show.

--
You received this message because you are subscribed to the Google Groups "Obey the testing goat! Test-Driven Web Development with Python book" group.
To unsubscribe from this group and stop receiving emails from it, send an email to obey-the-testing-goat-book+unsub...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

Adrian Scheffler

unread,
Apr 15, 2014, 5:48:35 AM4/15/14
to obey-the-test...@googlegroups.com
http://chimera.labs.oreilly.com/books/1234000000754/ch10.html#_django_pattern_processing_post_request_in_the_same_view_as_renders_the_form "Let’s added to our to-do list, and while we’re thinking about it, there’s one in home.html too"
https://github.com/hjwp/book-example/blob/master/lists/templates/list.html ( https://github.com/hjwp/book-example/commit/d1bb51c953626ca1d466f9e84b7df87299d92f96 ) "<<<<<<< HEAD=======" [...] ">>>>>>> db740dd... Add email form and sharee list to list template."

Adrian Scheffler

unread,
Apr 15, 2014, 12:17:55 PM4/15/14
to obey-the-test...@googlegroups.com
http://chimera.labs.oreilly.com/books/1234000000754/ch12.html#_another_ft_for_duplicate_items OK, so we know the first of the two tests passes now, is there a way to run just the failing one, I hear you ask! Why yes indeed:
Message has been deleted

Adrian Scheffler

unread,
Apr 15, 2014, 12:27:13 PM4/15/14
to obey-the-test...@googlegroups.com
In chapter 12 there is an inconsistence  with these stamps. For a while it says ch09l028 etc. instead of ch12|...

Adrian Scheffler

unread,
Apr 15, 2014, 4:48:05 PM4/15/14
to obey-the-test...@googlegroups.com

Adrian Scheffler

unread,
Apr 15, 2014, 6:24:38 PM4/15/14
to obey-the-test...@googlegroups.com
http://chimera.labs.oreilly.com/books/1234000000754/ch15.html#_mozilla_persona_browserid " In my book those all have unacceptable creepy overtones, why should Google or Facebook know what sites you’re logging into and when?" [...]"but a clever protocol means that they never need know"[...]

Adrian Scheffler

unread,
Apr 16, 2014, 12:58:43 PM4/16/14
to obey-the-test...@googlegroups.com
http://chimera.labs.oreilly.com/books/1234000000754/ch15.html#_a_common_selenium_technique_waiting_for ..."in your FT whenever you need to check for asynchronous interactions on your pages. We’ll see this again in ???."
http://chimera.labs.oreilly.com/books/1234000000754/ch15.html#_mocking_who_why_what "You may find you it’s worth re-reading the rest of the chapter a couple of times after you get to the end of it, to let it all sink in."
http://chimera.labs.oreilly.com/books/1234000000754/ch15.html#_namespacing "The code we’ll end up with in base.html will look like this:"
http://chimera.labs.oreilly.com/books/1234000000754/ch15.html#_a_simple_mock_to_unit_tests_our_initialize_function ..." If you forget, it’s a particularly fiendish test bug, because"...
http://chimera.labs.oreilly.com/books/1234000000754/ch15.html#_more_nested_callbacks_testing_asynchronous_code [23] ..."I thought this was probably one too many things to talk about!"...
A general thing: I wonder why you say in one place, that a test is best analysed from behind, while not explaining all tests that way (with these orange numbers).

Adrian Scheffler

unread,
Apr 17, 2014, 7:31:29 AM4/17/14
to obey-the-test...@googlegroups.com
Disclaimer: I am not a native english speaker, so there might be nothing. Just ignore these cases.
http://chimera.labs.oreilly.com/books/1234000000754/ch16.html#_patching_at_the_class_level "

Time for test for the positive case where authenticate should return a user object. We expect this to fail."

http://chimera.labs.oreilly.com/books/1234000000754/ch16.html#_beware_of_mocks_in_boolean_comparisons This section is slightly counterintuitive for  me, because i think this problem should be addressed right away, when the test is introduced and doesn't fail. At the beginning you mentioned the importance  of seeing the tests fail before fixing them and this seems to be a good example.

Adrian Scheffler

unread,
Apr 22, 2014, 7:05:12 PM4/22/14
to obey-the-test...@googlegroups.com
http://chimera.labs.oreilly.com/books/1234000000754/ch18.html#_the_next_requirement_from_the_views_layer_new_lists_should_record_owner
"But it won’t actually work, because don’t know how to save a list owner yet:"
http://chimera.labs.oreilly.com/books/1234000000754/ch19.html#_using_mock_side_effects_to_check_the_sequence_of_events
"Imagine if we accidentally call save before we we assign the owner:"
http://chimera.labs.oreilly.com/books/1234000000754/ch19.html#_rewriting_our_tests_for_the_view_to_be_fully_isolated
"Our first attempt at a test suite is for this view was highly integrated."
http://chimera.labs.oreilly.com/books/1234000000754/ch19.html#_removing_the_old_implementation_of_the_view
There is a orange one present in the code listing, while not being addressed.
http://chimera.labs.oreilly.com/books/1234000000754/ch21.html#_an_exercise_for_the_reader
" On the lists page, we want also want to show who the list is shared with, as well as mention of who the list owner is."
http://chimera.labs.oreilly.com/books/1234000000754/ch22.html
"There is an argument that an true unit test should always be isolated, because it’s meant to test a single unit of software."
http://chimera.labs.oreilly.com/books/1234000000754/ch22.html#_ports_and_adapters_hexagonal_clean_architecture
"Figure 22-1. Ports and Adapters (diagram by Nat Pryce)"(It's missing.)

Adrian Scheffler

unread,
Apr 22, 2014, 7:36:48 PM4/22/14
to obey-the-test...@googlegroups.com
http://chimera.labs.oreilly.com/books/1234000000754/apb.html#_using_form_valid_to_customise_a_createview
"We can see they’re both happening in the generiv view’s form_valid function, and"

Reply all
Reply to author
Forward
0 new messages