tweaks and things

[karl]

Feeds dialog will now be displayed on install and on update (whenever
the version number changes).

bumped version to 0.4.1

Prevent showing more than one notification at a time.

Checking for "live bookmarks loading..." notification

--
Karl Dearden
w: http://interclue.com/
e: ka...@interclue.com

[Dietrich Ayala]

fantastic, looks great karl!

[Joe Solomon]

Second the thumbs up!

The one thing I notice is that a notifications occurred a bit after the very latest re-install (also w/the last install)- that reads "Live Bookmark Loading".  Attached.  .. Any ideas? 

[karl]

>> The one thing I notice is that a notifications occurred a bit after the very
>> latest re-install (also w/the last install)- that reads "Live Bookmark
>> Loading". Attached. .. Any ideas?

bugger, I thought I'd solved that one with the last build.
Can you just confirm for me you're using 0.4.1 (tools|addons| should say
version number next to the addon name)?

It's a difficult bug to re-create as it relies on the notification being
sent before the download is complete.

Cheers
Karl

Joe Solomon wrote:
> Second the thumbs up!

>
> On Tue, Oct 7, 2008 at 10:01 AM, Dietrich Ayala <auto...@gmail.com>
> wrote:
>
>> fantastic, looks great karl!
>>
>> On Mon, Oct 6, 2008 at 11:29 PM, karl <ka...@interclue.com> wrote:
>>>
>>> Feeds dialog will now be displayed on install and on update
>>> (whenever the version number changes).
>>>
>>> bumped version to 0.4.1
>>>
>>> Prevent showing more than one notification at a time.
>>>
>>> Checking for "live bookmarks loading..." notification
>>>
>>>
>>> -- Karl Dearden w: http://interclue.com/ e: ka...@interclue.com
>>>
>
> >
>
>
>

> ------------------------------------------------------------------------
>
>

[Joe Solomon]

I checked and I am :(

I'll uninstall and see if it'll happen again.

[karl]

You'll have a hard time re-creating it. As the feeds get cached, and the
problem is complicated. I know what's going on, and will sort something
out soon.

Karl Dearden
w: http://interclue.com/
e: ka...@interclue.com

[Joe Solomon]

Sounds good! 

[karl]

Looks like Dietrich has a good solution that he's working on.
Will leave it up to him.

[Joe Solomon]

Ok, once this fix is in, I think we'll be ready to hit AMO. From there, the world! - Joe

[Dietrich Ayala]

ok, pushed the fix for alerts that'd we'd discussed. new xpi attached.

now, will only alert for the most recent feed item, and no alerts at
all for the first minute after startup. karl, can you review the
changes?

[karl]

Hi Dietrich ,

All looks good so far.

I'm interested in your use of "let" in overlay.js
--
let Cc = Components.classes;
let Ci = Components.interfaces;
--

According to the writeup at
http://developer.mozilla.org/En/New_in_JavaScript_1.7
{{{
var x = 'global';
let x = 42;
document.write(this.x + "<br>\n");
//The output displayed by this code will display "global", not "42"
}}}

So, correct me if I'm wrong here, if another add-on was loaded before
obamafox, and that addon contained the code
{{{
var Cc = null; //or anything other than Components.classes
}}}
in a global scope (as ours is).

Then this would break obamafox as soon as we tried to use the Cc
variable. Because the "var Cc" overrides the "let Cc" even though "let
Cc" is declared later in the code.

Now this all depends on how the add-on scripts are loaded (Of which I'm
not entirely certain).

I'd be interested to know what made you choose "let" here rather than
"var". What advantages to we get?

Cheers,
--

Karl Dearden
w: http://interclue.com/
e: ka...@interclue.com

[Dietrich Ayala]

Hey Karl,

Cc and Ci are already defined in the browser scope that extension code
is executed in. Using |let| here ensures that they're defined for our
use, without conflicting with the previously defined variables/consts
with those names. That said, yeah it's imprecise at best. Actually,
given that the extension only works in Firefox 3, could probably be
removed altogether, so I'll just do that.

-d

[Joe Solomon]

Hey guys - So the conversation is admittedly a bit too technical for me to understand ;)  - but it sounds like the next version is almost there!  Dietrich - Let me know when a new xpi is ready-to-go and I'll upload, nominate, and we can blow ObamaFox out of the water before the next debate!

Also, one last feed, if possible to add:

CNN

CNN Political Ticker

http://rss.cnn.com/rss/cnn_politicalticker.rss

Thanks!

Best,

Joe

[Abimanyu Raja]

I added the CNN feed.

And apologies for not being able to contribute much (school's been rough...).

- Abi

2008/10/14 Joe Solomon <j...@engagejoe.com>

[Joe Solomon]

Thanks Abi! 

[Dietrich Ayala]

new version attached, updated to 0.5. thanks for adding the feed Abi!

[Joe Solomon]

Awesomeness! I updated the new version to AMO and nominated us for review!  We're rolling!   -- Joe