a couple of comments:
- the feed selection dialog has no title on mac. it's just an
undecorated dialog w/ a list of feeds and checkboxes
- it'd be awesome to have a visual indication that the tabs are
configurable, on the popup itself. possible something like the "new
tab" button on browsers would work: a little end-tab with a plus sign,
that would open the feed selection dialog?
cheerio,
-d
> the feeds are fantastic, thanks Karl!
Yup, definitely adds value to the add-on, and makes it more useful.
> - the feed selection dialog has no title on mac. it's just an
> undecorated dialog w/ a list of feeds and checkboxes
Hmmm, I haven't done anything weird with the styles?
I don't have easy access to a mac though. Can anyone else look into this?
> - it'd be awesome to have a visual indication that the tabs are
> configurable, on the popup itself. possible something like the "new
> tab" button on browsers would work: a little end-tab with a plus sign,
> that would open the feed selection dialog?
Was pondering the same thing myself, but couldn't come up with anything
better than a options button next to the close button. The "new tab"
idea is much better. Will get right on it.
On another note, I've solved the styling problem for the alerts
notification, but found this comment
"alerts misbehaving, so removing for now"
when looking into displaying the alerts. I can't remember what the
problem was. Can anyone shed any light on this?
--
Karl
karl wrote:
> On another note, I've solved the styling problem for the alerts
> notification, but found this comment
> "alerts misbehaving, so removing for now"
> when looking into displaying the alerts. I can't remember what the
> problem was. Can anyone shed any light on this?
Yeah, that would be me. Feel free to disregard that comment and activate
the alerts again.
At the time, the alerts weren't working because of an un-declared
variable, but we also didn't agree on how to go about doing the alerts
in the first place. Joe also wanted to release a version, so because we
didn't have a stable, releasable branch, i removed it so it won't be in
the released extension. I know; Long story for such a small change. :)
- --
Regards,
Alaa Salman
Entrepreneur, Contractor, Programmer
http://www.codedemigod.com
Free Software Foundation Associate Member #6304
"One machine can do the work of fifty ordinary men. No machine can do
the work of one extraordinary man." ---Elbert Hubbard
"Never measure the height of a mountain until you have reached the top.
Then you will see how low it was." ---Dag Hammarskjold
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFI5ShE1JnzU8yXnzYRAoTeAJ9HLLVWaIa5jkjvNFid9gEqhOVVlQCePJmS
W1aS513h9plv6qq+dKDEZ9o=
=aaQ5
-----END PGP SIGNATURE-----
i can look at this tonight probably.
On Thu, Oct 2, 2008 at 1:00 PM, Alaa Salman <al...@codedemigod.com> wrote:
>
> IIRC, those are the nsIAlertsService alerts, right?
Yup,
> The growl
> notifications are cool, but kind of blend in with whatever music I'm
> playing, or twitters, so not the best vehicle for "important"
> notifications. Those should do for now, but I'd really like to use the
> "notification box" code that we use for the reader to make little
> popup notifications that are styled like the rest of the extension, so
> that it's clear that it's an important campaign-related alert.
I see what you mean. I've managed to style the nsIAlertsService dialog
(see attached), but this wont work on a mac. I believe macs use growl.
So we're probably better off using a custom popup or window instead.
--
Karl
karl wrote:
> I see what you mean. I've managed to style the nsIAlertsService dialog
> (see attached), but this wont work on a mac. I believe macs use growl.
> So we're probably better off using a custom popup or window instead.
I just wanted to say that the screenshot looks great Karl. I was under
the impression that there's a limit to how much you can style the
alerts. Since last time i had to do that, i hit several road blocks.
Apparently, i was wrong. So now i learned something new. Thanks :)
By the way, if i remember correctly, macs do use growl. There was a
pretty old bug on mozilla's bugzilla related to alerts and macs. I
believe it was fixed for FF 3.0..its a pretty famous bug, so i am sure
you can find it with a quick search if you're interested in reading up
about it.
- --
Regards,
Alaa Salman
Entrepreneur, Contractor, Programmer
http://www.codedemigod.com
Free Software Foundation Associate Member #6304
"One machine can do the work of fifty ordinary men. No machine can do
the work of one extraordinary man." ---Elbert Hubbard
"Never measure the height of a mountain until you have reached the top.
Then you will see how low it was." ---Dag Hammarskjold
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFI5m8G1JnzU8yXnzYRAiezAJ9BiaD3tSOM0qCMzh7EYJ29zN5p+QCglIOt
jk5qeavAsshZqVIUAHQXpNw=
=tRkx
-----END PGP SIGNATURE-----
Cheers,
I'll have a look around for it later on.
Small problem with when showing multiple tabs with large names (ObamaHQ,
Twitter, Economists and Donate). The tabs are expanding wider than the
popup and are hiding the options tab.
I'm working on it.
Karl