Fwd: Mozilla Add-ons: ObamaFox - Barack Obama Firefox Extension Nomination

[Joe Solomon]

Congrats to all! We are now (or will be very soon) public!

Huge shout out to Alex Polvi for the review (see below)

---------- Forwarded message ----------
From: Mozilla Add-ons <nob...@mozilla.org>
Date: Tue, Oct 14, 2008 at 11:21 AM
Subject: Mozilla Add-ons: ObamaFox - Barack Obama Firefox Extension Nomination
To: obam...@gmail.com


Congratulations! Your nominated add-on, ObamaFox - Barack Obama Firefox Extension, has been reviewed by a Mozilla Add-ons editor who approved your add-on to be public.

Your most recent version (0.5) has also been made public.

You can view your public add-on now at: http://addons.mozilla.org/addon/8586

Review Information:
Reviewer: Alex Polvi
Comments: Pushing public ... but ... in the next version please consider:<br />
<br />
Please remove any unneeded files, such as .DS_Store and __MACOSX directory (doesn't seem to hold anything). <br />
<br />
Also, this would not stop me from pushing public, but I had a hard time figuring out how to get rid of the news source selection window on first one, since there was no button. Finally realized I needed to his ESC. <br />
<br />
Great work!

If you have questions about this review, please e-mail amo-e...@mozilla.org or join #addons on irc.mozilla.org.

Mozilla Add-ons
http://addons.mozilla.org

[Abimanyu Raja]

Awesome! Although, I wonder how he couldn't find the close "X" button. I thought it was pretty obvious.

Joe, have you posted this addon on blogs like DailyKos, MyDD, etc.? That would probably be a good way to get the word out.

- Abi

2008/10/15 Joe Solomon <j...@engagejoe.com>

[Joe Solomon]

Abi - I just created an account on both Daily Kos and MDD - and found out they both have a one week delay for uploading articles.  Any chance you can hit one or two of these blogs to let the world know?

I'll be reaching out to bloggers, tweeting, and hitting forums today as well ... 

Thanks!

-- Joe 

[Dietrich Ayala]

On Tue, Oct 14, 2008 at 5:07 PM, Abimanyu Raja <abiman...@gmail.com> wrote:

> Awesome! Although, I wonder how he couldn't find the close "X" button. I
> thought it was pretty obvious.

on Mac it's a modal dialog with no buttons. i was also confused. i'll
try to fix this if i get time.

[Abimanyu Raja]

Oops.. I thought he meant the main ObamaFox popup. So, are you referring to the dialog where you choose news feeds? On OS X tiger, I have two buttons "Save" and "Cancel". Adding these attributes explicitly to prefwindow might work:

buttons="accept, cancel" buttonlabelcancel="Cancel" buttonlabelaccept="Save"

And I do have an account on DK. I'll post there and some other forums shortly.

- Abi

2008/10/16 Dietrich Ayala <auto...@gmail.com>

[karl]

If the popup is opened with "dialog" as one of it's attributes then (on
mac) it doesn't contain close buttons.

---
window.openDialog("chrome://obamafox/content/options.xul",
"obamafoxOptions",
"chrome,dialog,titlebar,toolbar,centerscreen,modal,resizable");

should become

window.openDialog("chrome://obamafox/content/options.xul",
"obamafoxOptions",
"chrome,titlebar,toolbar,centerscreen,modal,resizable");

Karl Dearden
w: http://interclue.com/
e: ka...@interclue.com

[Abi]

Made the two changes mentioned above. Let me know if there are close
buttons now.

- Abi

On Oct 16, 10:56 am, karl <k...@interclue.com> wrote:
> If the popup is opened with "dialog" as one of it's attributes then (on
> mac) it doesn't contain close buttons.
>
> ---
> window.openDialog("chrome://obamafox/content/options.xul",
> "obamafoxOptions",
> "chrome,dialog,titlebar,toolbar,centerscreen,modal,resizable");
>
> should become
>
> window.openDialog("chrome://obamafox/content/options.xul",
> "obamafoxOptions",
> "chrome,titlebar,toolbar,centerscreen,modal,resizable");
>
> Karl Dearden
> w:http://interclue.com/

> e: k...@interclue.com

>
> Abimanyu Raja wrote:
> > Oops.. I thought he meant the main ObamaFox popup. So, are you referring to
> > the dialog where you choose news feeds? On OS X tiger, I have two buttons
> > "Save" and "Cancel". Adding these attributes explicitly to prefwindow might
> > work:
>
> > buttons="accept, cancel" buttonlabelcancel="Cancel" buttonlabelaccept="Save"
>
> > And I do have an account on DK. I'll post there and some other forums
> > shortly.
>
> > - Abi
>

> > 2008/10/16 Dietrich Ayala <auton...@gmail.com>
>
> >> On Tue, Oct 14, 2008 at 5:07 PM, Abimanyu Raja <abimanyur...@gmail.com>

[Joe Solomon]

Abi - Thanks! I don't have a Mac, so can't test .. Can anyone test so we can update?

ObamaFox is really gaining traction @ 50-100 downloads a day - we're now @ 683 downloads and I expect we'll pass 1,000 this week!  

Also - I recently saw the notification load even though we hadn't triggered it  - it said something like "live bookmark failing to load" - I failed to grab a screenshot , although it looked like this earlier bug.

Dietrich, is it possible to look into this ?

Thanks all!

- Joe

[Dietrich Ayala]

On Sun, Oct 19, 2008 at 8:09 PM, Joe Solomon <j...@engagejoe.com> wrote:
> Abi - Thanks! I don't have a Mac, so can't test .. Can anyone test so we can
> update?

no buttons :(

> ObamaFox is really gaining traction @ 50-100 downloads a day - we're now @
> 683 downloads and I expect we'll pass 1,000 this week!

woo!

> Also - I recently saw the notification load even though we hadn't triggered
> it - it said something like "live bookmark failing to load" - I failed to
> grab a screenshot , although it looked like this earlier bug.
> Dietrich, is it possible to look into this ?

just checked in a possible fix for this. karl, can you review the
change when you have time?

cheers,

-d