Unit-tests (and revised patch for OAuthRequest.from_request)

8 views
Skip to first unread message

Morten Fangel

unread,
Jan 18, 2009, 4:46:34 AM1/18/09
to oaut...@googlegroups.com
Hi,

I've added the Unittests at
http://oauth.googlecode.com/svn/code/php/tests/

Currently three tests fail, which are
1) The bug in split_headers
(so someone test my patch so we can get
it commited)
2) The bug with port-numbers
(so again, test my patch)
3) The wrong handling of arrays in input

I've also revised my patch for the port-number
bug.. It's now way smaller because some of the
issue was already addressed in
get_normalized_http_url()

-fangel

PS: Boy, is Google Groups giving me issues..
I just wanted to couple my primary email with
my Google account, but due to some weird
bug in.. I don't know what, a lot of my emails
are rejected..

20080118_scheme_port_fix.patch

Morten Fangel

unread,
Jan 18, 2009, 5:01:36 AM1/18/09
to oaut...@googlegroups.com
bug in.. I don't know what, all of my emails
are rejected..
So now I've joined by the very inspiring alias
fangel.oauth.. ;)

20080118_scheme_port_fix.patch

Morten Fangel

unread,
Jan 18, 2009, 5:24:41 AM1/18/09
to oaut...@googlegroups.com
Hi,

I've added the Unittests at
http://oauth.googlecode.com/svn/code/php/tests/

Currently three tests fail, which are
1) The bug in split_headers
(so someone test my patch so we can get
it commited)
2) The bug with port-numbers
(so again, test my patch)
3) The wrong handling of arrays in input

I've also revised my patch for the port-number
bug.. It's now way smaller because some of the
issue was already addressed in
get_normalized_http_url()

-fangel


PS. Due to some weird G. Groups bug I couldn't
send emails from my primary account. So
created a new clean account. That should work..

So if this mail arrives a gazillion times, it's because
I tried various way to fix it so it worked with my
primary email
20080118_scheme_port_fix.patch
Reply all
Reply to author
Forward
0 new messages