64-bit build of framework

[Doug Richardson]

I needed a 64-bit compatible version of the framework but when I
created the 64-bit target the unit tests failed. The only thing that
looked suspicious was the SHA1 implementation used by hmac_sha1, so I
replaced the HMAC function in hmac_sha1.c with the Common Crypto
implementation, CCHmac, and the unit tests all passed.

Is there a reason CCHmac isn't used?

Thanks,
Doug

[Karl Adam]

No reason at all, and this is a good fix. Do you have a patch?

_Karl

[Douglas Richardson]

No, but I'd be happy to submit one. Should I follow the instructions here?

http://code.google.com/p/oauth/wiki/CodeReviewPractices

Doug

[Karl Adam]

Yes, that should be fine

_Karl

Sent from my iPhone