MPOAuthAPI.m initWithCredentials when url not in plist

4 views
Skip to first unread message

jrwpersonal

unread,
Jun 1, 2009, 5:56:18 PM6/1/09
to OAuth Objective-C
Just wondering if, perhaps, "initWithCredentials" should have a
default assignment of "oauthRequestTokenURL" to "inAuthURL" in-case
the _initAuthorizationEndpointsForURL fails to find anything for the
given domain?

Otherwise the inAuthURL parameter is not really used except for
"self.authenticationURL" which does not appear to be used.

Something like this, perhaps?

- (id)initWithCredentials:(NSDictionary *)inCredentials andBaseURL:
(NSURL *)inBaseURL
{
...
...
//Set the inRequestTokenURL default
self.oauthRequestTokenURL = inAuthURL;

// load authorization endpoints from file
[self _initAuthorizationEndpointsForURL:inRequestTokenURL];
...
...
}

Thoughts?

Karl Adam

unread,
Jun 1, 2009, 6:36:26 PM6/1/09
to oauth-ob...@googlegroups.com
The authenticationURL was obsoleted mostly by the three properties,
oauthRequestTokenURL, oauthAuthorizeTokenURL, oauthGetAccessTokenURL.
It only still remains because I'm in the middle of a cleanup of the
code for OAuth Rev A and OAuth auto-discovery that I've not yet
committed.

_Karl
Reply all
Reply to author
Forward
0 new messages