Question about PolishState.cpp

[René]

I See this code in PolishState.cpp

if (space.isFIR()) {
return string("0x01");
} else if (space.isDanger()) {
return string("0x02");
} else if (space.isRestricted()) {
return string("0x03");
} else if (space.isByNOTAM()) {
return string("0x04"); etc

What happens if Danger or Restricted is true AND ByNOTAM is true?
Regards

René

[Bart Vandewoestyne]

With the code as it is written now, a Danger zone that is activated by
NOTAM will still get the linetype of a Danger zone in the Polish files.
Similarly for a Restricted zone...

Thinking about it, this indeed might not be what we want. I see that I
encountered this situation before when implementing the polygon and line
type for KML files. See the KMLState::getPolygonType and the
KMLState::getLineType functions. There, i first check if the space is
by NOTAM.

We should probably also do this for the PolishState::getPolygonType and
PolishState::getLineType methods. Is this what you are suggesting?

I totally agree that the logic inside the getPolygonType and getLineType
methods (for both KML and PolishState output) probably can be
improved... It's a good exercise to think about the priorities of
assigning polygon and polyline types...

I'm currently quite busy and don't have a lot of time for coding...
I'll create an issue on oaconvert's github page so that we don't forget
to take a look at this in the future. However, also feel free to play
with the source code, re-compile and experiment! If you spot problems
or have good ideas on line-coloring etc, just post them in the oaconvert
group!

Regards,
Bart