river_poly

[Glen Barnes]

http://wiki.openstreetmap.org/wiki/Waterway
http://wiki.openstreetmap.org/wiki/Tag:waterway%3Driverbank
--
RP: are the ways closed? riverbank requires that they are. it also requires they are oriented a particular way. see the wiki for more information
--
HB: yes, they are closed areas (thus "_poly"). Water should be on the right side of the way, land on the left. Note this layer has no river name or direction associated with it, that's in river_cl.
--
Earmarked layer to export using reversed (CW) ways.
Chatham Isl uploaded 5 May 2010 (HB).
Stewart Isl uploaded 29 Dec 2010 in changeset 6794995 (HB).
--
HB 22 Aug 2012: looks good to me for the mainland.

waterway=riverbank 

Looks good to me.

[Hamish]

Glen wrote:
> Looks good to me.

marked as approved.


Hamish B

[Andin]

Where in the river_cl layer are the names?  I have done a few test areas for river_cl and not found any names.  I read that they "stick out like a sore thumb in josm", but haven't seen anything. from looking at here, it shows that some of the data I have uploaded should have contained some of the river names.

[Hamish]

Andin wrote:
> Where in the river_cl layer are the names? I have done a few test areas for
> river_cl and not found any names. I read that they "stick out like a sore thumb
> in josm", but haven't seen anything. from looking at here, it shows that some
> of the data I have uploaded should have contained some of the river names.

they are not in the rivel_cl layer, they are in the geographic_name
layer, but that has not yet been approved for the mainland or
uploaded.

from the geographic_names Notes section, it looks like it is almost
ready but needs more (deep) testing:

"""HB 26 Aug 2012: added all tagging rules used in:
Antarctic, Antipodes Islands, Auckland Islands, Bounty Islands,
Campbell Islands, and Kermadec Islands. The mainland has also had its
tagging coded but we should double check that none were missed (search
for those without tags after ignoring LINZ:*= and name=)."""


what you'll see in josm is a single node with a 3mm x 3mm yellow
square icon with a red "no" circle with a diagonal cross through it.
This is because a inherently linear feature (the river) has been
tagged as a single point by the geographic_point layer.

That name gets merged to the river_cl centre-line way, not the
river_poly riverbank which overlaps it.

You'll have to keep an eye out/use local knowledge and manually
promote anything that's really a substantial river to waterway=river.
Probably anything covered by a river_poly polygon is a good contender,
but I shy away from making generalizations as there's sure to be many
exceptions to any rule.

Once all the river_cl and geographic_name features are uploaded and
merged, it is not hard to do a search for remaining unmerged
river/stream names and doing a spatial search to suggest the nearest
waterway for review. I've already written the python script for doing
that as part of the old c.2010 conflict identification & merging
methods from before we got the web app. So in the long run nothing
should fall through the cracks, even if they do in the short term.


regards,
Hamish