A question about implementation of native_window

[Michael Morrison]

Is there any reason why native_window_win uses a standard chromium widget, while native_window_gtk and mac use the native interfaces directly? It seems like a lot of extra node-webkit code that we don't need to be maintaining if we don't need to.

-- Michael

[Roger]

IIRC there is no native UI widget support with an unified interface inside chromium. If
there is we'd like to use it to save our effort.

On Mon, Apr 22, 2013 at 3:26 PM, Michael Morrison <di...@sonicsnes.net> wrote:

Is there any reason why native_window_win uses a standard chromium widget, while native_window_gtk and mac use the native interfaces directly? It seems like a lot of extra node-webkit code that we don't need to be maintaining if we don't need to.

-- Michael

--
You received this message because you are subscribed to the Google Groups "node-webkit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to node-webkit...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Michael Morrison]

Check out chromium/src/chrome/browser/ui/***/extensions/native_app_window_***

Chromium is maintaining most of the same UI code as we are for their own app extension interface.

-- Michael

[Roger]

On Wed, Apr 24, 2013 at 9:26 PM, Michael Morrison <di...@sonicsnes.net> wrote:
> Check out
> chromium/src/chrome/browser/ui/***/extensions/native_app_window_***

Yeah. We are reusing code from there.

Roger

[Michael Morrison]

Ah, no wonder it looks so similar. Do the upstream changes from those files ever get merged in? It seems like the node-webkit implementation is missing some features like ShowInactive

-- Michael

[Roger Wang]

It's supposed to be sync with upstream. The same applies to other
components we brought. But unfortunately I didn't find much free time to
do so.

Roger