nwjs sanity tests

[Chang Rebecca Swee Fun]

Hi all, I was looking at the sanity tests listed in nw.js/test/sanity/. Some of the tests are accessing a folder named nwdist. I have problem locating / generating that particular folder in order to run tests. Is that a dummy test folder that one need to create for the test? Do you have any information regarding the sanity tests? Thanks.

[Ayushman Chhabra]

nwdist does seem like a temporary folder to store nw files.

https://github.com/nwjs/nw.js/blob/3e895da916088e9858484b4690ce982dc3aeba32/test/sanity/package/test.py#L48

The above command seems to copy nw files into the nwdist folder. I think you can create it before running the tests.

[Chang Rebecca Swee Fun]

The above command is copying from nwdist to pkg1 folder, and the content of nwdist is not mentioned, unless I understand it wrong.

Looks like some static files in nwjs build bot. Hope can get some insights as I would really love to run the test to check my work.

[Ayushman Chhabra]

Hi Rebecca,

 

Looks like you have a NW build going, that's awesome!

Have you ever come across this error?
https://github.com/nwjs/chromium.src/issues/156

I'm almost done but getting blocked by a missing library. NW's Chromium builds for me, Node also builds but fails at the link stage.

[Rebecca Chang]

Hi Ayushman,

 

Yes, I got NW65 running, I am porting and building for RISCV64. So I am not sure does it helps your issue. But I am working on nw65 in particular and have all the changes for nw65 in my github repo.

 

For linking issue, we have set use_lld = false, and we are using the host ld instead.

--
You received this message because you are subscribed to a topic in the Google Groups "nw.js" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/nwjs-general/YT47XwdNCSE/unsubscribe.
To unsubscribe from this group and all its topics, send an email to nwjs-general...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/nwjs-general/8573ee17-badf-4122-94a5-9e624b65ed01n%40googlegroups.com.

[Ayushman Chhabra]

Thanks! I'm currently running a build with the updated config. I have a question about the ninja build command from riscv-nwjs-patch repo's readme:

ninja -C out/nw nwjs -j128 -k0

How does one figure out how many tasks can be run in parallel (the -j flag)? According to the ninja manual, it runs tasks by default. What are the upsides/downsides of defining a specific -jN flag (where N is an arbitrary number)?

[Chang Rebecca Swee Fun]

Sorry Ayushman, I would like to focus back on the sanity tests topic where does the nwdist folder and required test files are generated.

As for the ninja build flags, I set it explicitely so that it will fully utilize my build server capability.

Hope we can get Roger's attention on the details of sanity test cases. Thanks.

[Roger Wang]

The 'nwdist' folder is generated when you run 'ninja dist'.

Regards,

Roger

On Tue, Oct 18, 2022 at 12:51 AM Chang Rebecca Swee Fun <rebecc...@starfivetech.com> wrote:

Hi all, I was looking at the sanity tests listed in nw.js/test/sanity/. Some of the tests are accessing a folder named nwdist. I have problem locating / generating that particular folder in order to run tests. Is that a dummy test folder that one need to create for the test? Do you have any information regarding the sanity tests? Thanks.

--
You received this message because you are subscribed to the Google Groups "nw.js" group.
To unsubscribe from this group and stop receiving emails from it, send an email to nwjs-general...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/nwjs-general/32ace269-aca1-4267-9e0f-ee92d866e6c1n%40googlegroups.com.

[Chang Rebecca Swee Fun]

Thanks Roger, I will definitely try out the command and build it. Thanks for the quick pointer. By the way, do you accept patches to support riscv64? I have a build running but that required a few patches on chromium side. Wonder if you are ok to maintain them in the main nwjs repo? I am still testing my local build to make sure things are functional. At this point, I have ran the sanity tests and 113/145 are passing, still pending to ninja dist to clear out the rest of the failed test cases.