Need help compiling on windows

[Boris Dudelsack]

Hello,

i'm compiling "nw" on a x64 windows machine using the automatic toolchain install as described here: http://www.chromium.org/developers/how-tos/build-instructions-windows

while compiling i'm getting the following error:

[2012/9704] CXX obj\ui\views\accessibility\views.native_view_accessibility_win.obj

FAILED: ninja -t msvc -o obj\ui\views\accessibility\views.native_view_accessibility_win.obj -e environment.x86 -- cl.exe /nologo /showIncludes /FC @obj\ui\views\accessibility\views.native_view_accessibility_win.obj.rsp  /c ..\..\ui\views\accessibility\native_view_accessibility_win.cc /Foobj\ui\views\accessibility\views.native_view_accessibility_win.obj  /Fdviews.pdb

d:\chromium\win_toolchain\win8sdk\include\shared\intsafe.h(150) : error C2220: warning treated as error - no 'object' file generated

d:\chromium\win_toolchain\win8sdk\include\shared\intsafe.h(150) : warning C4005: 'INT8_MIN' : macro redefinition

        d:\chromium\win_toolchain\vc\include\stdint.h(72) : see previous definition of 'INT8_MIN'

d:\chromium\win_toolchain\win8sdk\include\shared\intsafe.h(152) : warning C4005: 'INT16_MIN' : macro redefinition

        d:\chromium\win_toolchain\vc\include\stdint.h(73) : see previous definition of 'INT16_MIN'

d:\chromium\win_toolchain\win8sdk\include\shared\intsafe.h(154) : warning C4005: 'INT32_MIN' : macro redefinition

        d:\chromium\win_toolchain\vc\include\stdint.h(74) : see previous definition of 'INT32_MIN'

d:\chromium\win_toolchain\win8sdk\include\shared\intsafe.h(158) : warning C4005: 'INT64_MIN' : macro redefinition

        d:\chromium\win_toolchain\vc\include\stdint.h(149) : see previous definition of 'INT64_MIN'

d:\chromium\win_toolchain\win8sdk\include\shared\intsafe.h(173) : warning C4005: 'INT8_MAX' : macro redefinition

        d:\chromium\win_toolchain\vc\include\stdint.h(76) : see previous definition of 'INT8_MAX'

d:\chromium\win_toolchain\win8sdk\include\shared\intsafe.h(174) : warning C4005: 'UINT8_MAX' : macro redefinition

        d:\chromium\win_toolchain\vc\include\stdint.h(79) : see previous definition of 'UINT8_MAX'

d:\chromium\win_toolchain\win8sdk\include\shared\intsafe.h(177) : warning C4005: 'INT16_MAX' : macro redefinition

        d:\chromium\win_toolchain\vc\include\stdint.h(77) : see previous definition of 'INT16_MAX'

d:\chromium\win_toolchain\win8sdk\include\shared\intsafe.h(179) : warning C4005: 'UINT16_MAX' : macro redefinition

        d:\chromium\win_toolchain\vc\include\stdint.h(80) : see previous definition of 'UINT16_MAX'

d:\chromium\win_toolchain\win8sdk\include\shared\intsafe.h(182) : warning C4005: 'INT32_MAX' : macro redefinition

        d:\chromium\win_toolchain\vc\include\stdint.h(78) : see previous definition of 'INT32_MAX'

d:\chromium\win_toolchain\win8sdk\include\shared\intsafe.h(184) : warning C4005: 'UINT32_MAX' : macro redefinition

        d:\chromium\win_toolchain\vc\include\stdint.h(81) : see previous definition of 'UINT32_MAX'

d:\chromium\win_toolchain\win8sdk\include\shared\intsafe.h(190) : warning C4005: 'INT64_MAX' : macro redefinition

        d:\chromium\win_toolchain\vc\include\stdint.h(150) : see previous definition of 'INT64_MAX'

d:\chromium\win_toolchain\win8sdk\include\shared\intsafe.h(195) : warning C4005: 'UINT64_MAX' : macro redefinition

        d:\chromium\win_toolchain\vc\include\stdint.h(151) : see previous definition of 'UINT64_MAX'

[2012/9704] ACTION libcmt: libcmt_dbb8400d22fc705d3cc0692b87c9ccbc

ninja: build stopped: subcommand failed.

It seems to be a conflict between VC libs and WinSDK. I've found information about it here: http://connect.microsoft.com/VisualStudio/feedback/details/621653/including-stdint-after-intsafe-generates-warnings

Does anyone have an idea how to fix it without editing the chromium source code? 

[Roger WANG]

Boris Dudelsack <bdude...@gmail.com> writes:

> Hello,
>
> i'm compiling "nw" on a x64 windows machine using the automatic toolchain
> install as described
> here: http://www.chromium.org/developers/how-tos/build-instructions-windows
>
> while compiling i'm getting the following error:

Could you please provide more detail? e.g. VC and SDK versions.

--
Roger WANG Intel Open Source Technology Center

[Boris Dudelsack]

I'm generating the toolchaing by running:

python src\tools\win\toolchain\toolchain.py

As described here: http://www.chromium.org/developers/how-tos/build-instructions-windows#TOC-Automatic-simplified-toolchain-setup and http://src.chromium.org/viewvc/chrome?view=rev&revision=175004

It downloads VC ompiler (i guess from VC Express 2010), Win8 SDK, WDK and DXSDK.

Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 16.00.40219.01 for 80x86

Copyright (C) Microsoft Corporation.  All rights reserved.

[Boris Dudelsack]

Compiling original chrome works fine. So i guess there is wether a change somewhere in "\ui\views\accessibility" or an include of "intsafe.h" was added somewhere in nw's modified headers.

[Roger WANG]

Boris Dudelsack <bdude...@gmail.com> writes:

> Compiling original chrome works fine.

it depends on which version of chromium you built.

> So i guess there is wether a change somewhere in
> "\ui\views\accessibility" or an include of "intsafe.h" was added
> somewhere in nw's modified headers.

[Boris Dudelsack]

I've built the version from GIT (https://chromium.googlesource.com/chromium/src.git). Do you have some clues what it could be and where i should look

for the solution?

[Chaobin Zhang]

We have our own chromium repo in the Github: https://github.com/zcbenz/chromium

Have change the .gclient file according to the wiki https://github.com/rogerwang/node-webkit/wiki/Building-node-webkit

before gclient sync.

--
You received this message because you are subscribed to the Google Groups "node-webkit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to node-webkit...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

--

------------------

Best Regards 

----------------------------------------------------------------
@zhchbin , Chaobin Zhang (张朝滨）

School of Software, Sun Yat-sen University (Zhongshan University)

[Roger WANG]

Boris Dudelsack <bdude...@gmail.com> writes:

> I've built the version from GIT
> (https://chromium.googlesource.com/chromium/src.git). Do you have some
> clues what it could be and where i should look
> for the solution?

I'm not sure, but we don't use "Automatic simplified toolchain setup"
here. Just installing the tools and SDKs manually.

[Boris Dudelsack]

Do you use "component build" or "precompiled headers" while building for windows?

[Chaobin.Zhang]

I didn't build nw with "component build" or "precompiled headers". 

However, I haven't build the nw with the automatic toolchain, so I didn't run into your problem before.

[Boris Dudelsack]

The following patch seems to fix my build. I just don't understand why i'm the only one who has that error, because

automatic toolchain uses the same MSVC compiler as you. And there seems to be some change in actual chrome

git which fixes this issue, because it compiles without any problems.

 ui/views/views.gyp |    1 +

 1 file changed, 1 insertion(+)

diff --git a/ui/views/views.gyp b/ui/views/views.gyp

index dd0fa93..3bbaf3a 100644

--- a/ui/views/views.gyp

+++ b/ui/views/views.gyp

@@ -15,6 +15,7 @@

         'sources/': [ ['exclude', '_linux\\.(h|cc)$'] ],

       }],

     ],

+ 'msvs_disabled_warnings': [4005]

   },

   'targets': [

     {