[PATCH] Fix use of undefined pp-token #errror, other typos

28 views
Skip to first unread message

Juha Niskanen (Haltian)

unread,
Sep 19, 2019, 9:37:23 AM9/19/19
to NuttX
Hi Greg,

Another typo patch. Most significantly fixes multiple misspellings of the C preprocessor #error directive (well misspelling it should also cause a compile time error on most compilers I think...), also other typos mostly in comments, Kconfig and documentation, few in run-time strings.

Best Regards,
   Juha

0001-Fix-use-of-undefined-pp-token-errror-other-typos.patch

patacongo

unread,
Sep 19, 2019, 8:20:28 PM9/19/19
to NuttX


Another typo patch. Most significantly fixes multiple misspellings of the C preprocessor #error directive (well misspelling it should also cause a compile time error on most compilers I think...), also other typos mostly in comments, Kconfig and documentation, few in run-time strings.

Committed.  Sorry to be so slow.  It has been a long day.
Greg

Juha Niskanen (Haltian)

unread,
Sep 20, 2019, 3:19:37 AM9/20/19
to nu...@googlegroups.com
No need to hurry here.... But did you forgot the first patch? The one that fixes getcwd(). I don't see it in your tree.

Best Regards,
   Juha

From: nu...@googlegroups.com <nu...@googlegroups.com> on behalf of patacongo <spud...@gmail.com>
Sent: Friday, September 20, 2019 3:20 AM
To: NuttX <nu...@googlegroups.com>
Subject: [nuttx] Re: [PATCH] Fix use of undefined pp-token #errror, other typos
 


Another typo patch. Most significantly fixes multiple misspellings of the C preprocessor #error directive (well misspelling it should also cause a compile time error on most compilers I think...), also other typos mostly in comments, Kconfig and documentation, few in run-time strings.

Committed.  Sorry to be so slow.  It has been a long day.
Greg

--
You received this message because you are subscribed to the Google Groups "NuttX" group.
To unsubscribe from this group and stop receiving emails from it, send an email to nuttx+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/nuttx/b84db39a-3069-47f4-ab13-38a52aa4200e%40googlegroups.com.

Gregory Nutt

unread,
Sep 20, 2019, 8:27:35 AM9/20/19
to nu...@googlegroups.com

No need to hurry here.... But did you forgot the first patch? The one that fixes getcwd(). I don't see it in your tree.

Can you please check again.  There were some un-pushed changes on one of my PCs.  I do see this:

commit 5c853cd1dca1ab12dca2b25688dc45495a5b8557
Author: Juha Niskanen <juha.n...@haltian.com>
Date:   Thu Sep 19 06:14:53 2019 -0600

    libs/libc/unistd/lib_getcwd.c: remove stray sched_unlock().  Also fixes several typos.

I am not sure if that was one of the un-pushed changes changes or not.


Greg



Juha Niskanen (Haltian)

unread,
Sep 20, 2019, 10:47:15 AM9/20/19
to nu...@googlegroups.com
Yes, that was it. All is fine now. Thanks!

Sent from my Nokia X2

From: Gregory Nutt
Sent: ‎20.‎9.‎2019 15:27
To: nu...@googlegroups.com
Subject: Re: [nuttx] Re: [PATCH] Fix use of undefined pp-token #errror, other typos

--
You received this message because you are subscribed to the Google Groups "NuttX" group.
To unsubscribe from this group and stop receiving emails from it, send an email to nuttx+un...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages