Groups
Groups
Sign in
Groups
Groups
ns-3-reviews
Conversations
About
Send feedback
Help
TCP Cubic for ns-3 (issue 87740043)
69 views
Skip to first unread message
natale.pa...@gmail.com
unread,
Apr 16, 2014, 3:27:11 AM
4/16/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to natale.pa...@gmail.com, ns-3-r...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: ,
Message:
I found a bug in my code.. I'll update it soon
https://codereview.appspot.com/87740043/diff/1/src/internet/model/tcp-cubic.cc
File src/internet/model/tcp-cubic.cc (right):
https://codereview.appspot.com/87740043/diff/1/src/internet/model/tcp-cubic.cc#newcode398
src/internet/model/tcp-cubic.cc:398: m_ssThresh = std::max ((m_cWnd.Get
() * m_beta) / BICTCP_BETA_SCALE, 2U);
Ups, I forgot to multiply for m_segmentSize.
Description:
This is the v0.2 version of TCP Cubic for ns-3, available for review.
Please review this at
https://codereview.appspot.com/87740043/
Affected files (+648, -0 lines):
A src/internet/model/tcp-cubic.h
A src/internet/model/tcp-cubic.cc
Natale Patriciello
unread,
Apr 19, 2014, 8:36:23 AM
4/19/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to ns-3-r...@googlegroups.com, natale.pa...@gmail.com, re...@codereview-hr.appspotmail.com
Il giorno mercoledì 16 aprile 2014 09:27:11 UTC+2, Natale Patriciello ha scritto:
Reviewers: ,
Message:
I found a bug in my code.. I'll update it soon
Fixed. Anyway I'm actually trying to test the code against the Linux implementation, but DCE is really "hard" to setup.
natale.pa...@gmail.com
unread,
Apr 19, 2014, 8:33:27 AM
4/19/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to natale.pa...@gmail.com, ns-3-r...@googlegroups.com, re...@codereview-hr.appspotmail.com
http://codereview.appspot.com/87740043/
Reply all
Reply to author
Forward
0 new messages