LTE EPC upgrade (issue 353810043 by tomh.org@gmail.com)

[tomh...@gmail.com]

Reviewers: ,

Message:
Most of my comments are minor and should be easy to handle. Here are a
few not inline with the code:

1) The main comment that I have is that I don't see the need to add
'lena-simple-epc-upgrade.cc' which has only small differences from
'lena-simple-epc.cc'. I suggest to just make the small edits that you
want on 'lena-simple-epc.cc'.

2) Can you please edit CHANGES.html to add an item about the new
behavior enabled by this patch? What benefit or user impact do these
modifications bring to users (please state).

3) Could you please add a note (if it is not already there) to .rst
documentation that the underlying EPC network is IPv4 only, despite the
ability for EPC to handle IPv6 end-to-end from remote host to UE (if you
agree that this is a true statement).


https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design.rst
File src/lte/doc/source/lte-design.rst (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design.rst#newcode3150
src/lte/doc/source/lte-design.rst:3150: point-to-point NetDevice,
addressed to the appropiate SGW.
s/appropiate/appropriate

https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design.rst#newcode3155
src/lte/doc/source/lte-design.rst:3155: the outmost IP header matches
the SGW IP address). The local delivery
s/outmost/outermost

https://codereview.appspot.com/353810043/diff/1/src/lte/helper/point-to-point-epc-helper.cc
File src/lte/helper/point-to-point-epc-helper.cc (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/helper/point-to-point-epc-helper.cc#newcode398
src/lte/helper/point-to-point-epc-helper.cc:398: //packetSocket.Install
(enb);
should this code be deleted?

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-mme-application.cc
File src/lte/model/epc-mme-application.cc (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-mme-application.cc#newcode32
src/lte/model/epc-mme-application.cc:32: : m_gtpcUdpPort (2123)
suggest to add also here the comment //fixed by the standard

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-application.h
File src/lte/model/epc-pgw-application.h (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-application.h#newcode169
src/lte/model/epc-pgw-application.h:169: * \param msg GTPv2-C Create
Session Request message
\param packet

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-application.h#newcode175
src/lte/model/epc-pgw-application.h:175: * \param msg GTPv2-C Modify
Bearer Request message
\param packet

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-application.h#newcode181
src/lte/model/epc-pgw-application.h:181: * \param msg GTPv2-C Delete
Bearer Command message
\param packet

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-application.h#newcode187
src/lte/model/epc-pgw-application.h:187: * \param msg GTPv2-C Delete
Bearer Response message
\param packet

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-application.h#newcode220
src/lte/model/epc-pgw-application.h:220: *
\param protocolNumber

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-sgw-application.h
File src/lte/model/epc-sgw-application.h (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-sgw-application.h#newcode157
src/lte/model/epc-sgw-application.h:157: * \param header the GTP-C
header
delete \param header in this and several other methods in this class

Description:
LTE EPC upgrade (from Manuel Requena)

ns-3 issue: https://www.nsnam.org/bugzilla/show_bug.cgi?id=3022

Please review this at https://codereview.appspot.com/353810043/

Affected files (+4657, -219 lines):
M doc/models/Makefile
M src/lte/doc/Makefile
A src/lte/doc/source/figures/epc-data-flow-dl-with-split.dia
A src/lte/doc/source/figures/epc-data-flow-ul-with-split.dia
A src/lte/doc/source/figures/epc-topology-with-split.dia
M src/lte/doc/source/figures/helpers.seqdiag
A
src/lte/doc/source/figures/lte-epc-e2e-control-protocol-stack-with-split.dia
A
src/lte/doc/source/figures/lte-epc-e2e-data-protocol-stack-with-split.dia
M src/lte/doc/source/figures/nas-attach.seqdiag
M src/lte/doc/source/lte-design.rst
M src/lte/doc/source/lte-references.rst
A src/lte/examples/lena-simple-epc-upgrade.cc
M src/lte/examples/wscript
M src/lte/helper/point-to-point-epc-helper.h
M src/lte/helper/point-to-point-epc-helper.cc
A src/lte/model/epc-gtpc-header.h
A src/lte/model/epc-gtpc-header.cc
A src/lte/model/epc-mme-application.h
A src/lte/model/epc-mme-application.cc
A src/lte/model/epc-pgw-application.h
A src/lte/model/epc-pgw-application.cc
A src/lte/model/epc-sgw-application.h
A src/lte/model/epc-sgw-application.cc
M src/lte/model/epc-tft.h
M src/lte/model/epc-tft.cc
M src/lte/test/epc-test-s1u-downlink.cc
M src/lte/test/epc-test-s1u-uplink.cc
M src/lte/test/lte-test-ue-measurements.cc
M src/lte/wscript