Re: LTE EPC upgrade (issue 353810043 by tomh.org@gmail.com)

[manuel....@gmail.com]

All comments have been fixed. For the general comments:

1) I removed 'lena-simple-epc-upgrade.cc' as it was based on an old
'lena-simple-epc.cc'

2) done.

3) It is explained in "S1-U and S5 (data plane)" where we explain the
data flow.
Now I've added a point in the design choices:

#. The Packet Data Network (PDN) type supported is both IPv4 and IPv6.
In other words, the end-to-end connections between the UEs and the
remote
hosts can be IPv4 and IPv6. However, the networks between the core
network
elements (MME, SGWs and PGWs) are IPv4-only.



https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design.rst
File src/lte/doc/source/lte-design.rst (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design.rst#newcode3150
src/lte/doc/source/lte-design.rst:3150: point-to-point NetDevice,
addressed to the appropiate SGW.
On 2018/11/26 04:55:06, Tom Henderson wrote:
> s/appropiate/appropriate

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design.rst#newcode3155
src/lte/doc/source/lte-design.rst:3155: the outmost IP header matches
the SGW IP address). The local delivery
On 2018/11/26 04:55:06, Tom Henderson wrote:
> s/outmost/outermost

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/helper/point-to-point-epc-helper.cc
File src/lte/helper/point-to-point-epc-helper.cc (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/helper/point-to-point-epc-helper.cc#newcode398
src/lte/helper/point-to-point-epc-helper.cc:398: //packetSocket.Install
(enb);
On 2018/11/26 04:55:06, Tom Henderson wrote:
> should this code be deleted?

Yes. Done

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-mme-application.cc
File src/lte/model/epc-mme-application.cc (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-mme-application.cc#newcode32
src/lte/model/epc-mme-application.cc:32: : m_gtpcUdpPort (2123)
On 2018/11/26 04:55:06, Tom Henderson wrote:
> suggest to add also here the comment //fixed by the standard

Done. Also in doxygen of epc-mme-application.h

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-application.h
File src/lte/model/epc-pgw-application.h (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-application.h#newcode169
src/lte/model/epc-pgw-application.h:169: * \param msg GTPv2-C Create
Session Request message
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param packet

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-application.h#newcode175
src/lte/model/epc-pgw-application.h:175: * \param msg GTPv2-C Modify
Bearer Request message
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param packet

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-application.h#newcode181
src/lte/model/epc-pgw-application.h:181: * \param msg GTPv2-C Delete
Bearer Command message
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param packet

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-application.h#newcode187
src/lte/model/epc-pgw-application.h:187: * \param msg GTPv2-C Delete
Bearer Response message
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param packet

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-application.h#newcode220
src/lte/model/epc-pgw-application.h:220: *
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param protocolNumber

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-sgw-application.h
File src/lte/model/epc-sgw-application.h (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-sgw-application.h#newcode157
src/lte/model/epc-sgw-application.h:157: * \param header the GTP-C
header
On 2018/11/26 04:55:06, Tom Henderson wrote:
> delete \param header in this and several other methods in this class

Done.

https://codereview.appspot.com/353810043/