Re: ns-3 mptcp (issue 369810043 by kshfnadeem@gmail.com)

[natale.pa...@gmail.com]

Hi,

That's a huge work. It is impossible to review it in one time, and from
the little I have seen, you did not follow any of the TCP latest trend
(modularization and C++11 above all).

Let me put in another way: I hate inheritance, it is a pain in the ass
to maintain. If you want it to be merged, you have to take the
maintenance of the TCP in its entirely. Or, let's put a set of small
patches that can be applied incrementally so we can try to fix things.


https://codereview.appspot.com/369810043/

[kshfn...@gmail.com]

Hi Natale,

Thanks for your reviews. You are right it's a huge work and I spent lot
of time on this model. May be, I've missed some of TCP latest trends. If
you give me directions and point out things in my code which you think
should be modified according to latest TCP trends, I will work on it and
will revise this code.

I guess it's a big responsibility to maintain TCP along with MPTCP and
I'm not sure if I'm ready for this. You also mentioned we can work with
small patches to fix the things. I will work on it and will collaborate
with development team to merge this model.

https://codereview.appspot.com/369810043/

[kashif nadeem]

Hi,

 

I guess the problem is with your script and topology. MPTCP connection/flow isn’t getting mapping as expected. It may be the problem with TCP Sequence Numbers. You need to figure it out by debugging.

 

Sent from Mail for Windows 10

 

From: franci...@gmail.com
Sent: 19 December 2018 19:05
To: kshfn...@gmail.com; vivelep...@gmail.com; truca...@gmail.com; anng...@ittc.ku.edu; natale.pa...@gmail.com
Cc: ns-3-r...@googlegroups.com; re...@codereview-hr.appspotmail.com
Subject: Re: ns-3 mptcp (issue 369810043 by kshfn...@gmail.com)

 

Hi,

 

I have downloaded the patch and compiled MPTCP successfully in ns-3.28.

MPTCP works well when I run the example "mptcp-example.cc" but when I

try to test MPTCP in a spine-leaf topology,  the simulation ends with:

...

==== Dumping list of mappings ====

==== End of dump ====

 

msg="Could not find mapping associated to ssn",

file=../src/internet/model/mptcp-subflow.cc, line=289

terminate called without an active exception

 

Sorry I don't spend much time to check the code. I wonder what are the

possible reasons for this failure?

 

Thank you so much.

 

Best,

Francis

 

 

https://codereview.appspot.com/369810043/