Noor needs an icon an .desktop file.

[Mehmet Nur Olcay]

As im using noor on kde, it needs a .desktop file and an icon file, so it
really can be build from source and installed as package, has its menu entry
and icon in the menu.

What is needed:

1. noor.desktop, will be in -> /usr/share/applications/noor.desktop
2. noor.png, will be in ->/usr/share/pixmaps/noor.png

I'm attachging ones i have done for my Pardus 2008 .pisi package.

Regards..

[Ali Gholami Rudi]

Hi,

On Oct 30 2008 19:02 +0330, Mehmet Nur Olcay wrote:
> As im using noor on kde, it needs a .desktop file and an icon file, so it
> really can be build from source and installed as package, has its menu entry
> and icon in the menu.
>
> What is needed:
>
> 1. noor.desktop, will be in -> /usr/share/applications/noor.desktop
> 2. noor.png, will be in ->/usr/share/pixmaps/noor.png

Thanks. Does this patch work? (it actually copies these two files to
$prefix/share/applications and $prefix/pixmaps/; but I don't have KDE
to test it). Also Path variable in desktop.noor should be added when
installing noor (based on installation prefix). Can't the name of the
file (which is in PATH) be used? (instead of the address; like
noorgtk.pyw)

Regards,
Ali

diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -41,5 +41,7 @@
scripts=['noorgtk.pyw', 'noorhtmls.py', 'noortxt.py'],
package_data={'noor': ['data/*.xml', 'data/*.txt',
'data/icons/*.png', 'locale/*/LC_MESSAGES/*o']},
+ data_files=[('share/applications/', ['noor.desktop']),
+ ('share/pixmaps/noor.png', ['noor.png'])],
license='GNU GPL',
classifiers=classifiers)

[Mehmet Nur Olcay]

On Thursday 30 October 2008 19:03:18 Ali Gholami Rudi wrote:

> Thanks. Does this patch work? (it actually copies these two files to
> $prefix/share/applications and $prefix/pixmaps/; but I don't have KDE
> to test it). Also Path variable in desktop.noor should be added when
> installing noor (based on installation prefix). Can't the name of the
> file (which is in PATH) be used? (instead of the address; like
> noorgtk.pyw)
>
> Regards,
> Ali
>
> diff --git a/setup.py b/setup.py
> --- a/setup.py
> +++ b/setup.py
> @@ -41,5 +41,7 @@
> scripts=['noorgtk.pyw', 'noorhtmls.py', 'noortxt.py'],
> package_data={'noor': ['data/*.xml', 'data/*.txt',
> 'data/icons/*.png',
> 'locale/*/LC_MESSAGES/*o']}, + data_files=[('share/applications/',
> ['noor.desktop']),
> + ('share/pixmaps/noor.png', ['noor.png'])],
> license='GNU GPL',
> classifiers=classifiers)

The patch looks OK to me. bytheway, i did some other changes to run it from
konsole easily. I created symlinks for "noor*.py" files as "noor*". So, when
you write just "noorgtk", without .py[w], the gtk gui is starting, same for
other noor guis.

Then desktop file must be like this for general purpose:
--------------------------------------------------------------
[Desktop Entry]
Exec=noorgtk.pyw
Icon=/usr/share/pixmaps/noor.gtk
Categories=Application;Education;GTK;
GenericName=Quran viewer
GenericName[tr]=Kur'an Okuma Programı
Comment=A python Quran viewer
Comment[tr]=Kur'an Okuma Programı
Type=Application
Name=noor
Name[tr]=Nur
---------------------------------------------------------------

Or, if you want to create desktop files also for html and txt forms of noor,
u have to make two more desktop files with needed Exec changes. But i think
gtk one is enough. Never used html or txt one...

It's your decision at all..

[Ali Gholami Rudi]

Hi,

On Oct 30 2008 20:45 +0330, Mehmet Nur Olcay wrote:
> The patch looks OK to me. bytheway, i did some other changes to run it from

Thanks for reviewing.

> konsole easily. I created symlinks for "noor*.py" files as "noor*". So, when
> you write just "noorgtk", without .py[w], the gtk gui is starting, same for
> other noor guis.

Should I drop noor*.py in favor of noor*?

> Then desktop file must be like this for general purpose:
> --------------------------------------------------------------
> [Desktop Entry]
> Exec=noorgtk.pyw
> Icon=/usr/share/pixmaps/noor.gtk
> Categories=Application;Education;GTK;
> GenericName=Quran viewer
> GenericName[tr]=Kur'an Okuma Programı
> Comment=A python Quran viewer
> Comment[tr]=Kur'an Okuma Programı
> Type=Application
> Name=noor
> Name[tr]=Nur
> ---------------------------------------------------------------

Thanks. I'll add it to the repository tomorrow, insha'Allah.

> Or, if you want to create desktop files also for html and txt forms of noor,
> u have to make two more desktop files with needed Exec changes. But i think
> gtk one is enough. Never used html or txt one...

Actually noorgtk is the only one that actually has a GUI.

Regards,
Ali

[Ali Gholami Rudi]

Hi,

On Oct 30 2008 22:17 +0330, Ali Gholami Rudi wrote:
> Thanks. I'll add it to the repository tomorrow, insha'Allah.

It has been added. But it is not tested :-)

Regards,
Ali