Would you consider a change to update dependency lock files?

[Sandro B]

Hello!

  I'm from the GCP Secret Manager team and noticed that your project is using Secret Manager v1 but still has dependencies referencing v1beta1.

  Would you consider a PR that only removes the secretmanager v1beta1 references? I don't see v1beta1 referenced anywhere in the code anymore. I'm also not too familiar with gradle so I don't know if this would just be considered to be a noisey change without a real win.

Thanks!

[Lai Jiang]

Hi Sandro,

We are just starting to migrate to secret manager. I don't see any reason why we'd depend on v1beta1.

Weimin Yu (weiminyu@) has the most context.

Thanks,

[Weimin Yu]

Hi Sandro,

Our project pulls in com.google.api.grpc/proto-google-cloud-secretmanager-v1beta1 as an indirect dependency 

because the secretmanager client library declares it as a dependency.

Gradle will stop pulling it in if it is removed from secretmanager client project's pom.xml. 

--
NOTE: This is a public discussion list for the Nomulus domain registry project.
---
You received this message because you are subscribed to the Google Groups "nomulus-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to nomulus-discu...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/nomulus-discuss/fe4582a0-be5a-4c04-b295-98c3113a95e4n%40googlegroups.com.

[Sandro B]

Ahh sorry that was an oversight on my part. Thank you for pointing that out! 

On Wed, Feb 10, 2021 at 3:57 PM 'Weimin Yu' via nomulus-discuss <nomulus...@googlegroups.com> wrote:

Hi Sandro,

Our project pulls in com.google.api.grpc/proto-google-cloud-secretmanager-v1beta1 as an indirect dependency 

because the secretmanager client library declares it as a dependency.

Gradle will stop pulling it in if it is removed from secretmanager client project's pom.xml. 

On Wed, Feb 10, 2021 at 3:07 PM 'Lai Jiang' via nomulus-discuss <nomulus...@googlegroups.com> wrote:

Hi Sandro,

We are just starting to migrate to secret manager. I don't see any reason why we'd depend on v1beta1.

Weimin Yu (weiminyu@) has the most context.

Thanks,

On Wednesday, February 10, 2021 at 2:58:35 PM UTC-5 Sandro B wrote:

Hello!

  I'm from the GCP Secret Manager team and noticed that your project is using Secret Manager v1 but still has dependencies referencing v1beta1.

  Would you consider a PR that only removes the secretmanager v1beta1 references? I don't see v1beta1 referenced anywhere in the code anymore. I'm also not too familiar with gradle so I don't know if this would just be considered to be a noisey change without a real win.

Thanks!

--
NOTE: This is a public discussion list for the Nomulus domain registry project.
---
You received this message because you are subscribed to the Google Groups "nomulus-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to nomulus-discu...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/nomulus-discuss/fe4582a0-be5a-4c04-b295-98c3113a95e4n%40googlegroups.com.

--
NOTE: This is a public discussion list for the Nomulus domain registry project.
---

You received this message because you are subscribed to a topic in the Google Groups "nomulus-discuss" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/nomulus-discuss/wiVB9H5ON5k/unsubscribe.
To unsubscribe from this group and all its topics, send an email to nomulus-discu...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/nomulus-discuss/CAO%2Bz2wXZE4Qy8-ofOjWUucscUaKiATuBHuFcQ_ZDqdj_hJnqtg%40mail.gmail.com.

--

Sandro | Badame | san...@google.com