oracledb-contrib node not working in http request/response flow (no response object)

[ctlem...@gmail.com]

I have installed oracle client & oracledb on my node-red host, I have installed the node node-red-contrib-oracledb in the node palette.

I can use the oracle node to select information from an Oracle database.

I now want to create a resftul webservice (web request by a url parameter passing an id to the oracle node, and outputting the results as json string to a http response).

This is not working. Node-red always tells me "no response object" and the webclient never ends properly & keeps running without getting a response.

The debug node does show the correct information so the oracle db node is working & retrieving the data correctly, but the flow is not returning it to a http response.

Is this a problem of my flow or is this a bug of the node-red-contrib-oracledb  node?

[Nick O'Leary]

Hi,

Somewhere in your flow, the msg.res property is being lost.

From that screenshot, there are two possible places - the Oracle node or your Function node. Before we can say its the Oracle node, you should check your Function node isn't responsible.

Nick

--
http://nodered.org
 
Join us on Slack to continue the conversation: http://nodered.org/slack
---
You received this message because you are subscribed to the Google Groups "Node-RED" group.
To unsubscribe from this group and stop receiving emails from it, send an email to node-red+unsubscribe@googlegroups.com.
To post to this group, send email to node...@googlegroups.com.
Visit this group at https://groups.google.com/group/node-red.
To view this discussion on the web, visit https://groups.google.com/d/msgid/node-red/10002678-abb1-4e76-9427-db07dee21242%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[ctlem...@gmail.com]

The content of the function node is :

msg.payload =  [msg.payload.empsapnr];

return msg;

[Nick O'Leary]

In which case, yes, it appears the oracle node is dropping msg.res and breaking your flow.

Nick

--
http://nodered.org
 
Join us on Slack to continue the conversation: http://nodered.org/slack
---
You received this message because you are subscribed to the Google Groups "Node-RED" group.
To unsubscribe from this group and stop receiving emails from it, send an email to node-red+unsubscribe@googlegroups.com.
To post to this group, send email to node...@googlegroups.com.
Visit this group at https://groups.google.com/group/node-red.

To view this discussion on the web, visit https://groups.google.com/d/msgid/node-red/56dd57ba-a81f-45f8-a14f-89cec956c6cd%40googlegroups.com.

[Colin Law]

To workaround this you could save msg.res to a flow context var in your fn node and put another fn node after the json node that adds it back into the message.

Colin

To view this discussion on the web, visit https://groups.google.com/d/msgid/node-red/CAF%3Dvhqf8gaWHX%2BvpSMfKGt%3DN7Kem0hT6qc3%2BSq4rwBqvgfnPew%40mail.gmail.com.

[ctlem...@gmail.com]

Thank you, is there any way to fix this myself, or should I try to contact the node contributor?

On Tuesday, April 17, 2018 at 11:17:49 AM UTC+2, Nick O'Leary wrote:

In which case, yes, it appears the oracle node is dropping msg.res and breaking your flow.

Nick

On 17 April 2018 at 10:16, <ctlem...@gmail.com> wrote:

The content of the function node is :

msg.payload =  [msg.payload.empsapnr];

return msg;

--
http://nodered.org
 
Join us on Slack to continue the conversation: http://nodered.org/slack
---
You received this message because you are subscribed to the Google Groups "Node-RED" group.

To unsubscribe from this group and stop receiving emails from it, send an email to node-red+u...@googlegroups.com.

[ctlem...@gmail.com]

Apparently this issue was already raised on the Github for the oracle node:

https://github.com/abreits/node-red-contrib-oracledb/issues/11 

[ctlem...@gmail.com]

The problem was fixed by Colin's approach:

 

[Nick O'Leary]

Just be aware that this workaround means you can only have one active request at any time. If two requests arrive, the second one will overwrite the req/res properties in flow context and the first request will send its response to the second request...

Nick

On 17 April 2018 at 12:52, <ctlem...@gmail.com> wrote:

The problem was fixed by Colin's approach:

 

--

http://nodered.org
 
Join us on Slack to continue the conversation: http://nodered.org/slack
---
You received this message because you are subscribed to the Google Groups "Node-RED" group.

To unsubscribe from this group and stop receiving emails from it, send an email to node-red+unsubscribe@googlegroups.com.

To post to this group, send email to node...@googlegroups.com.
Visit this group at https://groups.google.com/group/node-red.

To view this discussion on the web, visit https://groups.google.com/d/msgid/node-red/084a9d9c-f95f-452b-bf63-fee7102577b1%40googlegroups.com.

[ctlem...@gmail.com]

OK... so that is no solution at all :(

[Colin Law]

Good point.  That makes it a little trickier.  I see from the issue report that the problem has been fixed but presumably not released. So if you install the node directly from github then it should be ok. Something like this should do it I think (with -g if you need to install as global, which I see is suggested in the readme)

npm install git://github.com/abreits/node-red-contrib-oracledb.git

Colin

To view this discussion on the web, visit https://groups.google.com/d/msgid/node-red/CAF%3DvhqeKrosmtSH4s_NZMFVaZR0VOXc9L3nTPZY1%3D-uzO50dhQ%40mail.gmail.com.

[ctlem...@gmail.com]

I see that nick asked the node contributor to update the package in npm to be able to do this with the palette functions. I see the update in npm, but not in the palette yet. Let's wait a while.

Thanks for all the help. 

[ctlem...@gmail.com]

Updated node-red-contrib-oracledb to 0.5.0, but the http request/response nodes are still not returning a response object. Posted that to github too.

[ctlem...@gmail.com]

I checked the bin\oracledb.js file for version 0.5.0, but the changes to pass the msg object inside these functions that were done by an intermediate update are not anymore in version 0.5.0...

[Colin Law]

On npm [1] it says the latest is 0.5.0 but on github [2] package.json is still showing 0.4.2 so something is not right somewhere.

Colin

[1] https://www.npmjs.com/package/node-red-contrib-oracledb
[2] https://github.com/abreits/node-red-contrib-oracledb

On 18 April 2018 at 09:55, <ctlem...@gmail.com> wrote:

I checked the bin\oracledb.js file for version 0.5.0, but the changes to pass the msg object inside these functions that were done by an intermediate update are not anymore in version 0.5.0...

--

http://nodered.org
 
Join us on Slack to continue the conversation: http://nodered.org/slack
---
You received this message because you are subscribed to the Google Groups "Node-RED" group.
To unsubscribe from this group and stop receiving emails from it, send an email to node-red+unsubscribe@googlegroups.com.
To post to this group, send email to node...@googlegroups.com.
Visit this group at https://groups.google.com/group/node-red.

To view this discussion on the web, visit https://groups.google.com/d/msgid/node-red/27e7e4f6-276a-4c9b-9777-1f04e0230147%40googlegroups.com.

[Nick O'Leary]

My guess is the maintainer (who in previous comments has said their time is limited to maintain the node), has updated package.json locally and published without having pulled down the latest code on github that includes the fix.

An easy mistake to make when trying to do something in a rush - I know I have.

Nick

To view this discussion on the web, visit https://groups.google.com/d/msgid/node-red/CAL%3D0gLtHc4u1XS%2B%3Dq-ncsDUhxwhfds5wEHPRo%2B8t6ZUpd5XcKA%40mail.gmail.com.

[ctlem...@gmail.com]

The maintainer has now updated once again, I will check the new version later this afternoon and post back the results.

[ctlem...@gmail.com]

I can confirm now that version 0.5.1 fixes the problem and now passes the original message correctly.
Http request/response nodes can now be used correctly in combination with the oracledb node.

Thanks everybody for the quick help & analysis. Keep up the good work!