Fixing some windows issues

4 views
Skip to first unread message

pi...@google.com

unread,
Apr 3, 2009, 3:16:14 AM4/3/09
to er...@google.com, nixysa...@googlegroups.com
Reviewers: ericu,

Message:
This CL adds a solution and project for Windows users, and fixes a
couple of Windows-related bugs.
The scons script is not functional on Windows yet.

Please review this at http://codereview.appspot.com/32117

Affected files:
M examples/complex/README
M examples/complex/SConstruct
A examples/complex/complex.def
A examples/complex/complex.rc
A examples/complex/complex.sln
A examples/complex/complex.vcproj
M examples/complex/plugin.cc
A examples/complex/resource.h
M nixysa/codegen.bat
M nixysa/static_glue/npapi/main.cc


er...@google.com

unread,
Apr 3, 2009, 5:46:23 PM4/3/09
to pi...@google.com, nixysa...@googlegroups.com
LGTM; just one comment fix.

Eric


http://codereview.appspot.com/32117/diff/1/10
File examples/complex/README (right):

http://codereview.appspot.com/32117/diff/1/10#newcode8
Line 8: plug-in automatically, run Firefox and load the sample page.
If it's going to run Firefox automatically, you want a comma after
Firefox. If that's something the user has to do, change the comma
before run to a semicolon.

http://codereview.appspot.com/32117

pi...@google.com

unread,
Apr 3, 2009, 6:12:38 PM4/3/09
to er...@google.com, nixysa...@googlegroups.com

> Eric

Fixed, and submitted.

http://codereview.appspot.com/32117

Reply all
Reply to author
Forward
0 new messages