code review 6056044: libdynld: add plan9ified libdynld to main tree. (issue 6056044)

10 views
Skip to first unread message

noah....@gmail.com

unread,
Apr 17, 2012, 5:01:38 AM4/17/12
to nixi...@gmail.com, rmin...@gmail.com, charles...@gmail.com, nix...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: Nixie, rminnich, charles.forsyth_gmail.com,

Message:
Hello nixi...@gmail.com, rmin...@gmail.com, charles...@gmail.com
(cc: nix...@googlegroups.com),

I'd like you to review this change to
https://noah....@code.google.com/p/nix-os/


Description:
libdynld: add plan9ified libdynld to main tree.
Libdynld is a library for dynamically loading code into an executable at
runtime. See http://www.vitanuova.com/inferno/man/10/dynld.html for more
information.

Please review this at http://codereview.appspot.com/6056044/

Affected files:
A sys/include/dynld.h
A sys/src/libdynld/NOTICE
A sys/src/libdynld/dynld-386.c
A sys/src/libdynld/dynld-386.o
A sys/src/libdynld/dynld-68000.c
A sys/src/libdynld/dynld-arm.c
A sys/src/libdynld/dynld-mips.c
A sys/src/libdynld/dynld-power.c
A sys/src/libdynld/dynld-sparc.c
A sys/src/libdynld/dynld-spim.c
A sys/src/libdynld/dynld.c
A sys/src/libdynld/dynloadfd.c
A sys/src/libdynld/mkfile


noah....@gmail.com

unread,
Apr 17, 2012, 5:31:58 AM4/17/12
to nixi...@gmail.com, rmin...@gmail.com, charles...@gmail.com, nix...@googlegroups.com, re...@codereview-hr.appspotmail.com

noah....@gmail.com

unread,
Apr 17, 2012, 5:32:32 AM4/17/12
to nixi...@gmail.com, rmin...@gmail.com, charles...@gmail.com, nix...@googlegroups.com, re...@codereview-hr.appspotmail.com

John Floren

unread,
Apr 17, 2012, 11:09:03 AM4/17/12
to nix...@googlegroups.com, nixi...@gmail.com, rmin...@gmail.com, charles...@gmail.com, re...@codereview-hr.appspotmail.com
LGTM, for a brief value of "look" :)

Noah Evans

unread,
Apr 17, 2012, 11:11:44 AM4/17/12
to nix...@googlegroups.com, nixi...@gmail.com, rmin...@gmail.com, charles...@gmail.com, re...@codereview-hr.appspotmail.com
It's not entirely ready yet. It still needs amd64 and it makes a lot
of 32bit assumptions. Charles do you have any pointers on how you
would do it?

Noah

Charles Forsyth

unread,
Apr 17, 2012, 11:51:59 AM4/17/12
to Noah Evans, nix...@googlegroups.com, nixi...@gmail.com, rmin...@gmail.com, re...@codereview-hr.appspotmail.com
Why is Reply-to: never what you want?

Anyway: oh, it obviously pre-dated uintptr, by several years in fact.
Um. I'd better check in umpteen places that I didn't subsequently update it somewhere.
Reply all
Reply to author
Forward
0 new messages