Re: code review 6222049: libmach: Fixed build problem. (issue 6222049)

11 views
Skip to first unread message

Noah Evans

unread,
May 21, 2012, 6:31:24 AM5/21/12
to MariusHi...@googlemail.com, noah....@gmail.com, nix...@googlegroups.com, re...@codereview-hr.appspotmail.com
LGTM

Noah


On Mon, May 21, 2012 at 11:21 AM, <MariusHi...@googlemail.com> wrote:
> Reviewers: npe,
>
> Message:
> Hello noah....@gmail.com (cc: nix...@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/nix-os/
>
>
> Description:
> libmach: Fixed build problem.
> mkfile in sys/src/libmach required 9c, which is
> not available in 9vx.
> A building code tree is a happy code tree.
>
> Please review this at http://codereview.appspot.com/6222049/
>
> Affected files:
>  M sys/src/libmach/mkfile
>
>
> Index: sys/src/libmach/mkfile
> ===================================================================
> --- a/sys/src/libmach/mkfile
> +++ b/sys/src/libmach/mkfile
> @@ -61,7 +61,6 @@
>  6obj.$O: /sys/src/cmd/6c/6.out.h
>  7obj.$O: /sys/src/cmd/7c/7.out.h
>  8obj.$O: /sys/src/cmd/8c/8.out.h
> -9obj.$O: /sys/src/cmd/9c/9.out.h
>  kobj.$O: /sys/src/cmd/kc/k.out.h
>  qobj.$O: /sys/src/cmd/qc/q.out.h
>  uobj.$O: uc/u.out.h
>
>

MariusHi...@googlemail.com

unread,
May 21, 2012, 5:21:28 AM5/21/12
to noah....@gmail.com, nix...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reply all
Reply to author
Forward
0 new messages