On 1/23/20 3:22 AM, Jan Niklas Hasse wrote:
> Is there a bug that needs the PR or is it just to improve performance?
Performance and convenience. The goal is to avoid requiring the build graph
to be loaded just to operate on the log file. However, I see from discussion
in PR 1721 that there may be path normalization requirements for the build
graph, and at least a deeper investigation may be needed.
I should have given more detail in my previous post but I mixed up the
long-existing recompact tool with the new cleandead tool and thought this
was just a quick fixup for a new tool. However it is actually a change to
an already-released tool and so needs more care.
The problem came up in CMake here:
CMake can work without the change if needed. I don't think this needs to
block the 1.10 release for Ninja.