New Maintainer for Ninja

637 views
Skip to first unread message

jha...@gmail.com

unread,
Jun 21, 2022, 3:10:55 PM6/21/22
to ninja-build
Hi everyone,

the 1.11.0 release took quite a while and I noticed that I don't have the time I'd like to work on Ninja. While there are quite a few people on GitHub helping out, I think it would be best if there was a maintainer who took over merging PRs and doing the whole release process. Maybe even multiple people?

Who would be interested? :)

Takuto Ikuta (生田 拓人)

unread,
Jun 22, 2022, 2:52:40 AM6/22/22
to jha...@gmail.com, ninja-build
Hi,

I (https://github.com/atetubou) am interested in maintaining Ninja as we are using Ninja heavily in chromium projects.
And I'd like to improve the build by improving Ninja's stability/performance.

Thanks,
Takuto

--
You received this message because you are subscribed to the Google Groups "ninja-build" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ninja-build...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ninja-build/38500b25-8ee2-4f68-9134-b052dcc396e7n%40googlegroups.com.


--
Takuto Ikuta
Software Engineer in Tokyo
Chrome Ops (chrome browser build team)

Nico Weber

unread,
Jun 22, 2022, 9:28:03 AM6/22/22
to Takuto Ikuta (生田 拓人), jha...@gmail.com, ninja-build
As a former maintainer: tikuta has contributed a few good patches to ninja before. I trust him to make good decisions for the project, so he has my support.

David Turner

unread,
Jun 22, 2022, 10:36:21 AM6/22/22
to Takuto Ikuta (生田 拓人), jha...@gmail.com, ninja-build
Hello,

I am (https://github.com/dturner5) too interested in maintaining Ninja, as my team is relying heavily on Ninja heavily to build Fuchsia.
My main interest  is in improving Ninja's correctness, diagnostics and performance in ways that benefit all users of the project and that avoids breaking existing workflows.
While I have not contributed much to Ninja so far (under my company account https://github.com/digit-google), I have submitted several important patches to the GN tool which produces Ninja manifests for both Chrome and Fuchsia.

I'd like to clarify that, even though tikuta and I both work for Google, we will be using our personal github accounts to work on Ninja, and that we'd be happy to have other maintainers coming from CMake or Meson too to help us.

Regards,

David,







Brad King

unread,
Jun 22, 2022, 2:12:16 PM6/22/22
to David Turner, Takuto Ikuta (生田 拓人), jha...@gmail.com, ninja-build, Kyle Edwards, Matthew Woehlke
On Wed, Jun 22, 2022 at 10:36 AM David Turner wrote:
> we'd be happy to have other maintainers coming from CMake or Meson too to help us.

Ninja is very important to CMake, so its success is important to Kitware.
We will be glad to help maintain Ninja.

Adding Matthew Woehlke and Kyle Edwards to Cc, who are interested
in helping. Kyle is the author of CMake's Ninja Multi-Config generator.

-Brad

Daniel Moody

unread,
Jun 22, 2022, 3:22:20 PM6/22/22
to Brad King, David Turner, Takuto Ikuta (生田 拓人), jha...@gmail.com, ninja-build, Kyle Edwards, Matthew Woehlke
I am the main contributor of ninja generation for SCons build system used by mongodb, and I have a lot of stake in ninja and would be interested in helping maintain it.

 

{ name     : "Daniel Moody",
  title    : "Sen Server Development Platform Eng",
  phone    : "321-506-6255",
  location : "Cedar Rapids, IA",
  twitter  : "@MongoDB",
  facebook : "MongoDB" }



--
You received this message because you are subscribed to the Google Groups "ninja-build" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ninja-build...@googlegroups.com.

LaMont Jones

unread,
Jun 22, 2022, 3:22:30 PM6/22/22
to jha...@gmail.com, ninja-build
While I haven't made contributions to Ninja yet, I have a long history in the open source community, starting with Debian and Ubuntu.

I (https://github.com/lamontj) would like to help with maintaining Ninja, which my team uses to build Android.  I'm interested in improving the performance and correctness of Ninja, without breaking current workflows.

--
You received this message because you are subscribed to the Google Groups "ninja-build" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ninja-build...@googlegroups.com.

jha...@gmail.com

unread,
Jun 23, 2022, 1:01:07 PM6/23/22
to ninja-build
Hi everyone,

I wouldn't have expected so many people :) We now have one each of the largest users of Ninja: Chromium, Fuchsia, CMake, SCons and Android. Only thing missing is Meson if I'm not mistaken.

@Nico: What do you think of requiring multiple reviewers on GitHub and having multiple people who can do that?

btw: Daniel, I just wanted to say that the Ninja support in SCons is AWESOME! Thank you so much for it.

Evan Martin

unread,
Jun 24, 2022, 12:55:21 AM6/24/22
to jha...@gmail.com, ninja-build
On Tue, Jun 21, 2022 at 12:10 PM jha...@gmail.com <jha...@gmail.com> wrote:
the 1.11.0 release took quite a while and I noticed that I don't have the time I'd like to work on Ninja. While there are quite a few people on GitHub helping out, I think it would be best if there was a maintainer who took over merging PRs and doing the whole release process. Maybe even multiple people?

Thank you so much for the time and effort you put into it!  I know it can sometimes feel thankless, so I personally wanted to say thank you, on behalf of all the people who quietly benefit from your work. 

Michael Jones

unread,
Jun 28, 2022, 7:50:37 AM6/28/22
to ninja-build
I would be happy to help with this.

Multiple people should be involved, not just one or two.

--
You received this message because you are subscribed to the Google Groups "ninja-build" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ninja-build...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages