PULL REQUEST: mifare / ultralight updates

40 views
Skip to first unread message

simon.y...@gmail.com

unread,
Jan 26, 2014, 6:26:27 AM1/26/14
to nfc-too...@googlegroups.com
Fork: https://code.google.com/r/simonyorkston-updates/

Summary
Several updates to the Mifare / Ultralight behaviour.

[Ultralight]
 - New 'i' switch. Dumps data about the current tag, and quits
 - Code updated to support ultralight compatible chipsets of varying size
(NTAG20X, FUDAN, Infineon my-d etc)
  - Automatically detects card size, and will adjust dumping / writing
facilities as such.

[Mifare]
 - New 'i' switch. Dumps data about the current tag (including size) and quits.
 - Code updated to support unattended writes - 'q' - will perform a full write,
no questions asked. Mainly used to writing to Chinese 'Magic' cards.

Hope you find it useful.

Philippe Teuwen

unread,
Jan 27, 2014, 6:09:27 PM1/27/14
to nfc-too...@googlegroups.com, Simon Yorkston
Hello Simon

You removed Adam's commit in your own commit:
https://code.google.com/r/simonyorkston-updates/source/detail?r=b01cd54262701e8bd1e2d7fbeb07ff5ef7f12c07

That's not the way it's supposed to work.
Please start from code of latest git commit on master branch and add you
code without destroying anything else.
it's also easier for us to review and accept your proposed changes if
you do that in several commits, one commit per added functionality,
rather than all at once.

Thank you for your comprehension.

Phil


On 01/26/2014 12:26 PM, simon.y...@gmail.com wrote:
> Fork: https://code.google.com/r/simonyorkston-updates/
>
> *Summary*
> --
> You received this message because you are subscribed to the Google
> Groups "nfc-tools developers group" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to nfc-tools-dev...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Simon Yorkston

unread,
Jan 27, 2014, 6:10:47 PM1/27/14
to Philippe Teuwen, nfc-too...@googlegroups.com
Hi Philippe.
Sorry, wasn't intentional - I guess that my local copy wasn't caught up with master before I shot it up to the clone.
I'll pull it back down, test and push.

Thanks for the head's up.
Simon
Reply all
Reply to author
Forward
0 new messages