Follow up on https://github.com/newspeaklanguage/newspeak/pull/125

[Milan Zimmermann]

Hi Gilad,

I thought I'd check if you saw my changes and the commit I added last week to 

https://github.com/newspeaklanguage/newspeak/pull/125

There is absolutely no rush, but in case additions to a PR do not generate emails, I just wanted to send a pointer here,

Thanks,

Milan

[Gilad Bracha]

Hi Milan,

Sorry, I did see them, but have been remiss in responding. I will take care of it this weekend.

--
You received this message because you are subscribed to the Google Groups "Newspeak Programming Language" group.
To unsubscribe from this group and stop receiving emails from it, send an email to newspeaklangua...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/newspeaklanguage/CAEc2VK13gzQnxS-k9VCHpt4yQUb9B%2BTg52xMztB9jc7bt587Rg%40mail.gmail.com.

--

Cheers, Gilad

[Milan Zimmermann]

No rush at all Gilad, I just was not sure my changes there generate any notifications. Thanks for the follow up, Milan

To view this discussion on the web visit https://groups.google.com/d/msgid/newspeaklanguage/CAOq-cNwVK9r4py6NJjQ-NsaS%2B4RmxkcxnpSt%2B7cCaS2_98%2B4Fw%40mail.gmail.com.

[Gilad Bracha]

They do generate notifications - but I have to look at my github notifications to see them; which I did. I wanted to get back to you, but have been caught up in other stuff.

To view this discussion on the web visit https://groups.google.com/d/msgid/newspeaklanguage/CAEc2VK21Xby%3D4%2BxxTp6u0TFxve-kMz%2Bo9NtP9wZacsJ5X_gQSw%40mail.gmail.com.

--

Cheers, Gilad

[Milan Zimmermann]

Sounds good, thanks.

To view this discussion on the web visit https://groups.google.com/d/msgid/newspeaklanguage/CAOq-cNzwZVW_7z_VEamiXaYpkcFPnTjO_rekxc3M%3D9YXBaL5pA%40mail.gmail.com.

[Gilad Bracha]

Hi Milan,

Thank you for all your work on this. I've accepted the changes, and then tweaked the README a bit to suit my own predilections. It's all live now. I will soon test it all out - both the recommended set up, from scratch, and the modified version that suits my personal use pattern.

[Milan Zimmermann]

Gilad,

Thanks, and let me know here or on the PR (I will be checking notifications there) if any changes are needed.

Later,

Milan

To view this discussion on the web visit https://groups.google.com/d/msgid/newspeaklanguage/41569038-c228-4547-b604-9a95a1524c9dn%40googlegroups.com.

[Milan Zimmermann]

Gilad,

I have one update on the merge of the PR #125 (it is closed, so I am responding here, not sure responding in the PR would reach your email).

There was a understandable confusion during the merge that we should fix before you start testing. Let me summarize it here:

1. The file 'platforms/webIDE/sw.js' should have the version line as follows:

const pwaVersion = 1;

2. The file 'pwa-deployed-versions/newspeaklanguage.org.version' should contain number 44  (or any larger number, no newline at the end)

44

The reason is, as follows: 

The version-update code function 

'copy_sw_to_http_dir_increasing_pwa_version'

 assumes the presence of the string

'const pwaVersion = 1;'

in 

 'platforms/webIDE/sw.js'

then uses the last used version number from  'pwa-deployed-versions/newspeaklanguage.org.version', increases it by 1, and copies the resulting 'sw.js' into the directory where the HTTP server is running.

Can you please make the two changes (in 1. and 2. above) before you start your testing? 

Let me know if I need to clarify it better,

Milan

[Gilad Bracha]

Got it. I was trying this on a different machine, but ran into some git issue and put it off. I also need to get things working on my machine. So I will incorporate your changes, Thanks!

[Gilad Bracha]

Ok, left you some comments in #125. I put back the small changes you mentioned above.

[Milan Zimmermann]

Thanks Gilad, let me know if you run into any issues, Milan

To view this discussion on the web visit https://groups.google.com/d/msgid/newspeaklanguage/ab56feb3-0636-44e2-bb56-1d22179c9747n%40googlegroups.com.