On Tue, Oct 18, 2016 at 03:04:12AM -0700, Tanguy Kerdoncuff wrote:
>Let me know if you need me to do some changes or if you feel this is
>ready for a PR.
I'd rather you submit a PR and we use GitHub's code review tooling to
iterate on it. I will be able to easily comment on specific lines, for
example, and then view yet unreviewed updates that you've just pushed.
But before that, do two things:
1. Remove the last commit where you merge my master into your branch,
because when merged, it will just pollute history.
On a related note: it looks like you developed directly in master
branch. It's not a very good approach, for a number of reasons. Maybe
read a few sections from here to get the idea:
if you need one.)
2. Format your commit messages properly. Here's a good write-up on the
(Scroll down to "The
seven rules of a great git commit message" if you're in a hurry.) You
can easily do that with `git rebase --interactive`.