Total Rej articles reorted as twice the size of actual rejected articles

[John F. Morse]

Something I've noticed for quite a few years in the Daily Usenet report
for the "NNRP readership statistics."

The bottom-line TOTAL of the Rej articles column is always double the
sum of the individual values.

In the following section, "NNRP readership statistics (by domain)," the
TOTAL is correct.

This is INN 2.4.5 and the bug also appeared in INN 2.4.3.

Was this corrected in later versions, and is there a fix for 2.4.5?

--
John

[Julien ÉLIE]

Hi Johnn

What I can tell you is that I do not see the problem on the daily
reports I have with INN 2.5.1.
(And I do see it with an old INN 2.4.3 I have.)

I do not remember a recent bug fix on that column. Maybe Alexander does (?)

http://inn.eyrie.org/trac/changeset/7934

[innreport.conf]
- value "$nnrpd_post_rej{$key} +
- $nnrpd_post_error{$key}";
+ value "($nnrpd_post_rej{$key}||0) +
+ ($nnrpd_post_error{$key}||0)";

But I do not think that mere change (addinf "||0") will fix the bug.

--
Julien ÉLIE

« C'est comme chercher une aiguille dans du foin en bottes ! »
(Jolitorax)

[Julien ÉLIE]

Hi John,

Did you try the suggestion of my previous article?
Did it change something?

In case you are interested in another patch, I have just found out a "wrong"
total in the "Outgoing feeds (innfeed) by Articles" section.
Patch here:

http://inn.eyrie.org/trac/changeset/8846/trunk/scripts/innreport_inn.pm

Fix a bug in the daily Usenet report: a few lines did not
appear in the report whereas the total still took them
into account. These lines do not appear when the peer
does not respond during the whole day. They now appear
(and every article is marked as spooled).

--
Julien ÉLIE

« Je préfère glisser ma peau sous des draps pour le plaisir des sens
que de la risquer sous les drapeaux pour le prix de l'essence. » (Raymond Devos)

[John F. Morse]

Hi Julian.

Hope your Christmas was good. :-)

Julien ÉLIE wrote:
> Hi John,
>
>> Something I've noticed for quite a few years in the Daily Usenet report
>> for the "NNRP readership statistics."
>>
>> The bottom-line TOTAL of the Rej articles column is always double the
>> sum of the individual values.
>>
>> In the following section, "NNRP readership statistics (by domain)," the
>> TOTAL is correct.
>>
>> This is INN 2.4.5 and the bug also appeared in INN 2.4.3.
>>
>> Was this corrected in later versions, and is there a fix for 2.4.5?
>
> Did you try the suggestion of my previous article?
> Did it change something?

It was already as your suggestion shows.

[innreport.conf]
- value "$nnrpd_post_rej{$key} +
- $nnrpd_post_error{$key}";
+ value "($nnrpd_post_rej{$key}||0) +
+ ($nnrpd_post_error{$key}||0)";

So, I was waiting on your other idea:

"I do not remember a recent bug fix on that column. Maybe Alexander
does (?)"

Perhaps he didn't see this?

--
John

When a person has -- whether they knew it or not -- already rejected the Truth, by what means do they discern a lie?