hi beerfan,
Thanks for the feedback. I've replied below.
On Jul 2, 5:33 pm, beerfan <
beer...@gmail.com> wrote:
> 1. Page layout does not XUL. I haven't looked at the code (yet) but
> this is my guess based on the layout behavior. For example, if the
> window width is less than the width of all columns then the columns
> wrap. The page should be reimplemented with XUL using flexible
> elements. I could provide a template that I created if aid is needed
> here.
You're right about XUL, it's kind of mix and match, some of it is XUL,
some is XBL, some of it is HTML. I'm not really happy with the
solution and I want to make it a bit simpler to maintain in future so
it is due for rewrite for the next release. If you have a ready
template lying around then please send it to me, you have my email, it
might be helpful. However, if you look at code it's not that straight
forward with layout, some of it is set in JavaScript, some in XBL
mappings.
> 2. Thumbnail controls (shown on hover) should be removed. Options for
> each page should be, instead, added to a context menu. This would
> eliminate the possibility of users accidentally clicking X and the
> need to remove the page from history after a browser restart. It is
> also less distracting. Those controls are rarely needed and are
> essentially a power user feature. Finally, a context menu is needed
> for tabs anyway to provide core options like "open in new tab".
>
That's a good point, I'll see to include context menu for the next
release, however I probably won't be touching controls for now.
> 3. The extension branding should be minimized. The tab icon is very
> colorful and attracts the eye too much, in my opinion. I recommend
> using The tab label should be shortened to "New Tab", similar to
> Chrome. This will make the feature feel more like a core function of
> Firefox rather than a flashy un-integrated addon.
>
I won't be touching that for now, for example Google toolbar has much
bigger images for branding.
> 4. The extension should honor "Private Browsing" by not storing
> history or thumbnails for pages while in private browsing mode. I
> haven't tested this so perhaps it is a non-issue.
>
That's a very good point, I was thinking lately about it sine I am
rewriting that part. I think it should not be a problem at the moment
due to how the extension works.
It will not work properly with history turned off - it loads the list
of thumbs to show at the beginning of the session so if there was
nothing in history it will not show anything. Since in private mode it
won't keep anything in history the extension won't show anything. So
the extension is not very useful in private mode at the moment, I'm
still thinking about it, if you have any suggestions I would be glad
to hear them.
> I have other more minor suggestions which I will mention at another
> time.
Please do, I'm open for suggestions. I wish people who were commenting
on the add-ons site rather posted their suggestions here, so be sure
any of your feedback is very welcomed.
Thanks,
Mihailo