PR #7974 - AlphaCore algorithm - label request and dependency issue

40 views
Skip to first unread message

Prachi Saibewar

unread,
Apr 17, 2025, 7:47:52 AMApr 17
to networkx-discuss
Dear NetworkX Maintainers,

I've submitted PR #7974 implementing the AlphaCore algorithm, and I'm encountering two issues:

1. The CI check indicates a label is missing. Could someone please add the appropriate label (likely "enhancement" or "new feature") to my PR?

2. Despite adding "algorithms/alphacore.py" to both the needs_numpy and needs_pandas lists in conftest.py, I'm still getting error.

I'm not sure why the conftest.py changes aren't preventing the error. Should I also update my alphacore.py file to use conditional imports? Any guidance would be greatly appreciated, as this is my first contribution to NetworkX.

Thank you for your assistance!

Regards,
Prachi

Prachi Saibewar

unread,
Jun 4, 2025, 1:17:24 AMJun 4
to networkx-discuss
Hi NetworkX Maintainers, 

I have submitted a pull request to add the AlphaCore algorithm to NetworkX. The code and tests are ready, but the CI is failing because numpy and pandas are not installed with pip install .[test]. 

These dependencies are included in the [project.optional-dependencies].default section of pyproject.toml, but not in the test extra. Would you prefer that I add them to the test extra, or should the CI be updated to install both extras (e.g., pip install .[default,test])?

 Also, could someone please assign a reviewer to my PR? 

Thank you for your time and guidance!

Regards,
Prachi
Reply all
Reply to author
Forward
0 new messages