Draw MultiDiGraph edges and labels #7010

52 views

Skip to first unread message

Dom Grigonis

unread,

Oct 20, 2023, 10:24:06 AM10/20/23

to networkx...@googlegroups.com

Hi all,

I have done a bit of work and issued PR: https://github.com/networkx/networkx/pull/7010

It is not breaking any backwards compatibility and is ready to be merged. Could someone take a look and let me know if there are any issues with it or reasons why it can't (will not) be merged?

Secondly,

I was about to go down the path that I have laid out in the comment of making edge drawing and edge label drawing in sync. And incorporate work that has been done in https://github.com/networkx/networkx/issues/3813.

To achieve this sync, some refactoring is needed and certain functionality needs to be factored out from `currently independent on anything else` drawing functions. Also, some changes are inevitable. I think it is possible to avoid breaking backwards compatibility, but changes, such as self-loop height decoupling from certain parameters, are inevitable.

So I am a bit reluctant to go forward with this as I am not sure what boundaries I am in and I would need some guidance in this respect.

Also, I personally do not have any need for it as what I have done already is sufficient for my own needs. So I would only take this on if I was sure that my work is going to be reviewed and someone will make sure it is merged in the end.