Recent GH activities - 13:00 13-Jul-2012

2 views
Skip to first unread message

ne...@googlegroups.com

unread,
Jul 13, 2012, 9:00:03 AM7/13/12
to ne...@googlegroups.com
normanmaurer closed issue 455 on netty/netty
============================================
URL: https://github.com/netty/netty/issues/455

[normanmaurer][1] closed [issue 455][2] on [netty/netty][3] July 13, 2012

> Corrupted HTTP POST body

[1]: https://github.com/normanmaurer
[2]: https://github.com/netty/netty/issues/455 (Corrupted HTTP POST body)
[3]: https://github.com/netty/netty

normanmaurer commented on issue 455 on netty/netty
==================================================
URL: https://github.com/netty/netty/issues/455#issuecomment-6961309

[normanmaurer][1] commented on [issue 455][2] on [netty/netty][3] July 13, 2012

> Its a bug in webbit as you relay on ChannelBuffer.array(). This is a problem as: * You don't check if the ChannelBuffer is really backed by an array which would for example not the case with direct buffers * You don' respect the readerIndex and WriterIndex It worked before as we did a lot more buffer copies and so you was lucky enough the the ChannelBuffer was backed by an array which was exact the size of the content. This is not the case anymore as we use slice(..) when possible to save a memory copy. I will issue an pull request in webbit with the fix.

[1]: https://github.com/normanmaurer
[2]: https://github.com/netty/netty/issues/455#issuecomment-6961309 (Corrupted HTTP POST body)
[3]: https://github.com/netty/netty

normanmaurer commented on issue 455 on netty/netty
==================================================
URL: https://github.com/netty/netty/issues/455#issuecomment-6961432

[normanmaurer][1] commented on [issue 455][2] on [netty/netty][3] July 13, 2012

> done see https://github.com/webbit/webbit/pull/99

[1]: https://github.com/normanmaurer
[2]: https://github.com/netty/netty/issues/455#issuecomment-6961432 (Corrupted HTTP POST body)
[3]: https://github.com/netty/netty

Reply all
Reply to author
Forward
0 new messages