[TeamCity, FAILED] Build netty :: build-oraclejdk8-no-prefer-direct [4.1] #649

[team...@netty.io]

Build netty :: build-oraclejdk8-no-prefer-direct [4.1] #649 failed (Tests failed: 1 (1 new), passed: 13938, ignored: 140)

Agent: centos6-1

Changes included: 6 changes.

Change 3a4a0432d309dd17de86bd1cf4742030174fc190 by norman_maurer (2 files): Fix broken testsuite-shading when using with netty-tcnative-boringssl-static (#8404)

Motivation:

2109f14c24f90df3f43aee7f3248ac59e6088735 corrected how we run the testsuite with boringssl-static but missed to also adjust the testsuite-shading configuration which lead to test failures.

Modifications:

Correctly compose the native lib name when no classifier is used.

Result:

Testsuite passes again.

Change a6f807dd683243aa388aad0bfc9fcb20f3b1edce by langchristian96 (4 files): Fix context and window sizes sides. (#8395)

Motivation:

As mentioned in RFC 7692 :

The "server_no_context_takeover" Extension Parameter should be used on server side for compression and on client side for decompression.

The "client_no_context_takeover" Extension Parameter should be used on client side for compression and on server side for decompression.

Right now, in PerMessageDeflateClientExtensionHandshaker, the decoder uses clientNoContext instead of serverNoContext and the encoder uses serverNoContext instead of clientNoContext.

The same inversion is present in PerMessageDeflateServerExtensionHandshaker: the decoder uses
serverNoContext instead of clientNoContext, while the encoder uses serverNoContext instead of clientNoContext. Besides the context inversion, the sliding window sizes seem to be inversed as well.

Modification:

Inverse clientNoContext with serverNoContext and clientWindowSize with serverWindowSize for both the Decoder and Encoder in PerMessageDeflateServerExtensionHandshaker and PerMessageDeflateClientExtensionHandshaker.

Result:

This fixes the decompression fail in the case that one of the contexts is set and the other one is not.

Change 201e984cb3995d59cf8254f851f0ffb9090c2fea by norman_maurer (9 files): Allow to use TLSv1.3 with netty-tcnative withe java versions prior to 11. (#8394)

Motivation:

At the moment it's only possible to use TLSv1.3 with netty-tcnative if Java 11 is used. It should be possible to do so even with Java 8, 9 and 10.

Modification:

Add a workaround to be able to use TLSv1.3 also when using Java version prior to Java 11 and the default X509ExtendedTrustManager is used.

Result:

Be able to use TLSv1.3 also with past versions of Java.

Change 47e4a58d90fa627658f8957d2e984b108139474b by norman_maurer (10 files): Explicit specify java version to use to ensure we rebuild image when java version changes. (#8397)

Motivation:

We should explicit specify the java version to use to ensure docker will rebuild the image once a new java version was released and we specify it. Also we should use openjdk for testing when possible.

Modifications:

- Explicit specify the java versions to use
- Use openjdk when possible.

Result:

Ensure latest java versions are used during testing

Change f24da67a239da4b9a4f5e97565061006994d2f7a by norman_maurer (1 file): Update jetty-alpn-agent version to support latest JDK 8 release. (#8402)

Motivation:

We need to update jetty-alpn-agent to be able to run tests with OpenJDK 8u191

Modifications:

Update to 2.0.8

Result:

Be able to run tests with latest JDK 8 release.

Change 3543e17967699b89edba7436c932853f9580dd9c by norman_maurer (1 file): Ensure OpenSslEngine will not try to call SSL_free multiple times even when constructor throws. (#8399)

Motivation:

When the constructor of OpenSslEngine threw we could end up to self call SSL_free by ourself and then have the finalizer do the same which may lead to double free-ing and so SIGSEV.

Modifications:

Just call shutdown() when the constructor throws and so ensure SSL_free is guarded correctly in the finalizer.

Result:

No more SIGSEV possible.

Failed tests summary: 1 (1 new)

(new) io.netty.channel.epoll.EpollSocketShutdownOutputBySelfTest.testWriteAfterShutdownOutputNoWritabilityChange

details »

Stacktraces:

(new) io.netty.channel.epoll.EpollSocketShutdownOutputBySelfTest.testWriteAfterShutdownOutputNoWritabilityChange

java.lang.AssertionError: expected null, but was:<true>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotNull(Assert.java:755)
	at org.junit.Assert.assertNull(Assert.java:737)
	at org.junit.Assert.assertNull(Assert.java:747)
	at io.netty.testsuite.transport.socket.SocketShutdownOutputBySelfTest.testWriteAfterShutdownOutputNoWritabilityChange(SocketShutdownOutputBySelfTest.java:185)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at io.netty.testsuite.transport.AbstractTestsuiteTest.run(AbstractTestsuiteTest.java:62)
	at io.netty.testsuite.transport.socket.SocketShutdownOutputBySelfTest.testWriteAfterShutdownOutputNoWritabilityChange(SocketShutdownOutputBySelfTest.java:136)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)
------- Stdout: -------
23:21:20.266 [Time-limited test] INFO  i.n.c.e.EpollSocketShutdownOutputBySelfTest - Running: testWriteAfterShutdownOutputNoWritabilityChange 1 of 2 with UnpooledByteBufAllocator
------- Stderr: -------
java.lang.AssertionError: expected:<true> but was:<false>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at io.netty.testsuite.transport.socket.SocketShutdownOutputBySelfTest$TestHandler.assertWritability(SocketShutdownOutputBySelfTest.java:279)
	at io.netty.testsuite.transport.socket.SocketShutdownOutputBySelfTest.testWriteAfterShutdownOutputNoWritabilityChange(SocketShutdownOutputBySelfTest.java:159)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at io.netty.testsuite.transport.AbstractTestsuiteTest.run(AbstractTestsuiteTest.java:62)
	at io.netty.testsuite.transport.socket.SocketShutdownOutputBySelfTest.testWriteAfterShutdownOutputNoWritabilityChange(SocketShutdownOutputBySelfTest.java:136)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)

Configure your email notifications on your settings page.