Disconnect issues

[johna...@gmail.com]

I saw somewhere in the forum about disconnect problems. This was the
main reason starting developing my own firmwares as the problem was
very common in greece. I figured out there was a bug in the some
changes in pppd the linksys developers did. This is one of my first
patches, I just remove the linksys code leaving the vanilla pppd code.
Over 100 users are using my firmwares about a year and I didn't get a
single report for disconnect problem again. So it's perfectly safe to
merge it.

diff --git a/router/pppd/pppd/lcp.c b/router/pppd/pppd/lcp.c
index d4bb016..a053255 100644
--- a/router/pppd/pppd/lcp.c
+++ b/router/pppd/pppd/lcp.c
@@ -2110,24 +2110,6 @@ void LcpLinkFailure (f)
}

/*
- * Check if we have been received "echo reply" packet
- */
-
-static void LcpCheckReply(arg)
- void *arg;
-{
- //fsm *f1 = &lcp_fsm[ifunit];
- //junzhao 2004.7.9
- fsm *f1 = (fsm *)arg;
-
- if(lcp_echos_pending >= 1)
- TIMEOUT(LcpEchoTimeout, f1, 1);
- else
- TIMEOUT(LcpEchoTimeout, f1, lcp_echo_interval-1);
-}
-
-
-/*
* Timer expired for the LCP echo requests from this process.
*/

@@ -2135,9 +2117,7 @@ static void
LcpEchoCheck (f)
fsm *f;
{
- //junzhao 2004.7.9
- if(check_adsl_status())
- LcpSendEchoRequest (f);
+ LcpSendEchoRequest (f);
if (f->state != OPENED)
return;

@@ -2146,9 +2126,7 @@ LcpEchoCheck (f)
*/
if (lcp_echo_timer_running)
warn("assertion lcp_echo_timer_running==0 failed");
- //TIMEOUT (LcpEchoTimeout, f, lcp_echo_interval);
- //junzhao 2004.3.18
- TIMEOUT (LcpCheckReply, f, 1);
+ TIMEOUT (LcpEchoTimeout, f, lcp_echo_interval);
lcp_echo_timer_running = 1;
}

[Marco Vedovati]

oh thanks for your help,
btw have u tried using the last pppd (2.4.3)? Maybe there are some
improvements.

cheers

Il giorno 16/lug/07, alle ore 10:18, johna...@gmail.com ha scritto:

[johna...@gmail.com]

No I haven't try it. I don't think it worths so much trouble for
trivial improvements.

Have fun

On Jul 17, 5:34 pm, Marco Vedovati <marco....@gmail.com> wrote:
> oh thanks for your help,
> btw have u tried using the last pppd (2.4.3)? Maybe there are some
> improvements.
>
> cheers
>

> Il giorno 16/lug/07, alle ore 10:18, johnath...@gmail.com ha scritto: