neuprintr: small bug when progress=TRUE

[Romain Franconville]

Hi all, and thanks for the great work!

In neuprintr, it seems that, at least in the neuprint_connection_table function, when progress=TRUE, then the all_segments parameter is ignored and defaults to TRUE. 

Tangentially, there's no "Issue" section in the natverse fork of neuprintr, should we report issues directly to alexanderbates/neuprintr ?

Romain

[Greg Jefferis]

Thanks a lot for the bug report, Romain.

You're quite correct that the all_segments argument is not being passed on here:

https://github.com/natverse/neuprintr/blob/fb25dcb9c9a133a211b3614346f109d318f5affa/R/connectivity.R#L54

You are also right that the neuprintr repo is not optimally configured. It would have been better if we could have transferred Alex's original repo (alexanderbates/neuprintr)  to the natverse organisation rather than the fork (which used to be at jefferislab/neuprintr). I think we've go this right for all the other repos. I would suggest making an issue on the parent repo (alexanderbates/neuprintr) and we'll try to get them back in sync and then make natverse/neuprintr the parent.

@Alex I think you either need to blast the natverse fork and transfer your repo to the natverse organisation or perhaps contact GitHub support to detach them.

All the best,

Greg.

--
You received this message because you are subscribed to the Google Groups "nat-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to nat-user+u...@googlegroups.com.
To view this discussion on the web, visit https://groups.google.com/d/msgid/nat-user/ee030757-092a-442a-baf8-1f395f009b85%40googlegroups.com.