Binary throws on ByteString.prototype.__defineGetter__ on Firefox 4

[Christoph Dorn]

I am working on getting narwhal-xulrunner working on Firefox 4 (Gecko 2).

Having some problems with the binary module. Not sure what to do.

http://github.com/280north/narwhal/blob/master/engines/default/lib/binary.js#L206

Error: redeclaration of getter length

http://github.com/280north/narwhal/blob/master/engines/default/lib/binary.js#L209

Error: redeclaration of const length

Same for:

http://github.com/280north/narwhal/blob/master/engines/default/lib/binary.js#L455

http://github.com/280north/narwhal/blob/master/engines/default/lib/binary.js#L458

Any idea what the problem is and how this can be fixed?

Christoph

[Christoph Dorn]

Commenting this out seems to fix it:

http://github.com/280north/narwhal/blob/master/engines/default/lib/binary.js#L26

Christoph

[Kris Kowal]

On Fri, Oct 29, 2010 at 6:58 PM, Christoph Dorn
<christ...@christophdorn.com> wrote:
> Commenting this out seems to fix it:
> http://github.com/280north/narwhal/blob/master/engines/default/lib/binary.js#L26

Have we done anything to address this issue yet?

Tom, are there potential repercussions?

Kris Kowal

[Christoph Dorn]

On 10-11-03 9:21 PM, Kris Kowal wrote:
> On Fri, Oct 29, 2010 at 6:58 PM, Christoph Dorn
> <christ...@christophdorn.com> wrote:
>> Commenting this out seems to fix it:
>> http://github.com/280north/narwhal/blob/master/engines/default/lib/binary.js#L26
>
> Have we done anything to address this issue yet?

No.

> Tom, are there potential repercussions?

That is what I am wondering.

Christoph