Patch to fix protocol version

[Justin Johnson]

I don't know when this changed, but my backend now reports the
protocol version as 23056 (i.e. the backend version * 1000 + myth://
protocol version). This patch fixes how Mythdroid handles that. In
particular, this caused the recordings list to fail.

https://netfiles.uiuc.edu/jjohns63/www/Recordings.patch

[foo bar]

Hi Justin,

Strange; my backend is on protocol version 57 (later than yours?) yet
I still just get '57'. Will have a look at the myth sources, see
what's going on...

Regards,

foobum

[Justin Johnson]

On Aug 22, 10:46 pm, foo bar <foo...@gmail.com> wrote:
> Hi Justin,
>

> On 20 August 2010 02:52, Justin Johnson <justin.johns...@gmail.com> wrote:
>
> > I don't know when this changed, but my backend now reports the
> > protocol version as 23056 (i.e. the backend version * 1000 + myth://
> > protocol version). This patch fixes how Mythdroid handles that. In
> > particular, this caused the recordings list to fail.
>
> >https://netfiles.uiuc.edu/jjohns63/www/Recordings.patch
>
> Strange; my backend is on protocol version 57 (later than yours?) yet
> I still just get '57'. Will have a look at the myth sources, see
> what's going on...
>
> Regards,
>
> foobum

Interesting, the output of mythbackend --version for me is:

MythTV Version : 25368
MythTV Branch : branches/release-0-23-fixes
Network Protocol : 23056
Library API : 0.23.201000710-1
QT Version : 4.5.2
Options compiled in:
[deletia]

My installation is a mythbuntu installation, perhaps it has something
to do with that? At any rate, my patch checks if the protocol version
is greater than 1000 before adjusting. Without this patch I wasn't
able to view the recordings list. Mythdroid would see that 23056 > 57
and would try to use the new structure for accessing the programs
(particularly when sorting the arraylist in getRecordings()), when it
should have been using the structure for versions < 57. At any rate,
it works for me and I'll continue to use the patch with my system.

BTW, this app is great!! I love it. I've got a new Samsung Vibrant so
I'm trying to get the remote streaming to work a little better and
with higher resolution files (perhaps just the original recordings
since my hardware can easily handle it). I haven't looked into it much
though.

[Justin Johnson]

According to changeset 25366 in .23-fixes:
"Change the backend protocol version to '23056' to signify that
this is different than 56 in -fixes and -trunk. We have already
used '57' in trunk, so we don't want to use 57 here as set by
[25364].
The internal value is stored as a string, but MythWeb and the
bindings treat this as an int, so we couldn't just put '56b'
or some other non-numeric string."

[foo bar]

On 25 August 2010 00:04, Justin Johnson <justin....@gmail.com> wrote:
> According to changeset 25366 in .23-fixes:
> "Change the backend protocol version to '23056' to signify that
> this is different than 56 in -fixes and -trunk. We have already
> used '57' in trunk, so we don't want to use 57 here as set by
> [25364].
> The internal value is stored as a string, but MythWeb and the
> bindings treat this as an int, so we couldn't just put '56b'
> or some other non-numeric string."

Aha. Ok, cool, I'll commit a fix.

Thanks,

foobum