rocksdb.compression_zstd test and server compiled without ZStd.

[Sergei Petrunia]

Hello,

Currently, compression_zstd test fails when the server is compiled without ZStd:

rocksdb.compression_zstd                 w3 [ fail ]

        Test ended at 2016-11-14 13:26:21

Server log is:

[Note] Global variable initial value (from config file) @@open_files_limit = 1024

...

2016-11-14 13:26:20 8734 [ERROR] RocksDB: Error opening instance: Invalid argument: Compression type ZSTD is not linked with the binary.

2016-11-14 13:26:20 8734 [ERROR] Plugin 'ROCKSDB' init function returned error.

2016-11-14 13:26:20 8734 [ERROR] Plugin 'ROCKSDB' registration as a STORAGE ENGINE failed.

2016-11-14 13:26:20 8734 [Warning] /home/psergey/dev-git/mysql-5.6-rocksdb-look2/sql/mysqld: unknown option '--loose-enable-performance-schema'

2016-11-14 13:26:20 8734 [Warning] /home/psergey/dev-git/mysql-5.6-rocksdb-look2/sql/mysqld: unknown variable 'loose-performance-schema-accounts-size=100'

2016-11-14 13:26:20 8734 [Warning] /home/psergey/dev-git/mysql-5.6-rocksdb-look2/sql/mysqld: unknown variable 'loose-performance-schema-digests-size=200'

...

2016-11-14 13:26:20 8734 [ERROR] Unknown/unsupported storage engine: rocksdb

2016-11-14 13:26:20 8734 [ERROR] Aborting

I think ZStandard is not a requirement for MyRocks to work (if it is, then CMake script should refuse to compile without ZStandard).

I didn't want the test to fail, so for MariaRocks I've made this change:

https://github.com/MariaDB/server/commit/e370d0a9ae2f440b4f5ae100906c70c9e9e6b186

the patch

* Adds @@rocksdb_supported_compression_types variable which show what compression is compiled in

* Makes compression_zstd test skip itself when the server is not compiled with ZStandard.

Any opinions, should I submit this patch for MyRocks too? 

[Laurynas Biveinis]

Sergei -

> I think ZStandard is not a requirement for MyRocks to work (if it is, then
> CMake script should refuse to compile without ZStandard).
>
> I didn't want the test to fail, so for MariaRocks I've made this change:
>
> https://github.com/MariaDB/server/commit/e370d0a9ae2f440b4f5ae100906c70c9e9e6b186
>
> the patch
> * Adds @@rocksdb_supported_compression_types variable which show what
> compression is compiled in
> * Makes compression_zstd test skip itself when the server is not compiled
> with ZStandard.
>
> Any opinions, should I submit this patch for MyRocks too?

I cannot speak for upstream, but this patch would help our port too.

--
Laurynas

[Yoshinori Matsunobu]

Hi Sergey,

Yes, your patch would be useful for our repo too. Could you file a pull request for https://github.com/facebook/mysql-5.6 ?

- Yoshinori

--
You received this message because you are subscribed to the Google Groups "MyRocks - RocksDB storage engine for MySQL" group.
To unsubscribe from this group and stop receiving emails from it, send an email to myrocks-dev...@googlegroups.com.
To post to this group, send email to myroc...@googlegroups.com.
To view this discussion on the web visit https://urldefense.proofpoint.com/v2/url?u=https-3A__groups.google.com_d_msgid_myrocks-2Ddev_CAHkCEVctjW6YnPk82N39mkYPYEtGR-253D5grPAuTs-253D-2Du-5FZiQZy3KQ-2540mail.gmail.com&d=DgIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=h7I09O8mW25YOy83cdKu0g&m=ZTq_3JImeS_RFU9_x35fcYXigpP082ttuTYUMGOPfsw&s=yfN4HMcXqvLnjU3sW02X-dIyyaBDMj5fNctV5CxSdRQ&e= .
For more options, visit https://urldefense.proofpoint.com/v2/url?u=https-3A__groups.google.com_d_optout&d=DgIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=h7I09O8mW25YOy83cdKu0g&m=ZTq_3JImeS_RFU9_x35fcYXigpP082ttuTYUMGOPfsw&s=Ppxzsjsu7-qe19cLdnXBWqKunJzn1y5Fm9QZpShTQjY&e= .

[Sergei Petrunia]

Hi Yoshinori,

Ok I have filed an issue, and submitted a pull request:

https://github.com/facebook/mysql-5.6/issues/444

https://github.com/facebook/mysql-5.6/pull/446