I would like to contribute a feature

[Mathias Fritsch]

Hello,

I have a small project on codeplex that renders ViewData into a
formated table.
http://mvcrendermodel.codeplex.com

The project is usefull if you do a lot of UI-development and just need
to know what is going on in your Model.

Is there any chance to join mvccontrib with that project?

regards
Mathias

[Eric Hexter]

that looks really interesting.. Here is a link that talks about how to contribute.

http://mvccontrib.codeplex.com/Wiki/View.aspx?title=Contribute&referringTitle=Home

Look at item 2.  We do require unit tests for contributions.. I looked through your source code and did not see any tests so we would need to rectify that. 

The major issue we need to work out would be defining where this fits with the UI Grid that we have.. I think we have room for both features but we would want to make them have a consistent entry point.. Specificially should these be HtmlHelper extension methods rather than model extension methods. 

This is interesting to me because it starts to fill in the gap with the input builders I am working on and the view version of that.

Jeremy, what do you think?

Eric Hexter

Principal Consultant
Headspring Systems | www.HeadspringSystems.com
email: ehe...@HeadspringSystems.com
blog: Hex.LosTechies.com
-------------------------------------------------------------------------------------------------------------
Director - Austin .Net Users Group | www.ADNUG.org
Membership Mentor South Texas - INETA | www.INETA.org
Asp Insider | www.ASPInsiders.com

[Jeremy Skinner]

I've had a very brief look and this certainly looks interesting. This serves a different purpose to the existing grid, so I'd have no problem having both in the project side by side. As you say, this could complement the input builders quite nicely. I agree that for consistency, it might make sense to use extension methods on htmlhelper instead. 

Jeremy

2009/6/21 Eric Hexter <eric....@gmail.com>

[Mathias Fritsch]

Thank you for having a look at the project!
I will convert the thing to an HtmlHelper extension and add Unittests.

Mathias

[Mathias Fritsch]

Today I uploaded the patch with added tests.
It is now an HtmlHelper extension.

Mathias

[Eric Hexter]

I did not understand the Product Version comment in the patch notes.. Could you explain that part ?

Eric Hexter

Principal Consultant
Headspring Systems | www.HeadspringSystems.com
email: ehe...@HeadspringSystems.com
blog: Hex.LosTechies.com
-------------------------------------------------------------------------------------------------------------
Director - Austin .Net Users Group | www.ADNUG.org
Membership Mentor South Texas - INETA | www.INETA.org
Asp Insider | www.ASPInsiders.com

[Mathias Fritsch]

> I did not understand the Product Version comment in the patch notes..

To include the files for the extender and the unittest I had to change
the projectfiles MVCContrib.UnitTests.csproj and MVCContrib.csproj.

MVCContrib.UnitTests.csproj has a line <ProductVersion>9.0.21022</
ProductVersion>.
When I save MVCContrib.UnitTests.csproj it gets
<ProductVersion>9.0.30729</ProductVersion>.
I guess its because I have SP1 or because I work on a german system.

I dont know if your existing workflow for evaluating patches allows
for correcting such glitches.
If not I just upload a different patch.

Mathias

[Eric Hexter]

Ok.. that makes more sense....  We will figure out that portion of the file.  As long as the build compiles through the command line tools the version of studio should not matter.

Eric Hexter

Principal Consultant
Headspring Systems | www.HeadspringSystems.com
email: ehe...@HeadspringSystems.com
blog: Hex.LosTechies.com
-------------------------------------------------------------------------------------------------------------
Director - Austin .Net Users Group | www.ADNUG.org
Membership Mentor South Texas - INETA | www.INETA.org
Asp Insider | www.ASPInsiders.com