Simple Patch for CommandLineOptions.java

[Martijn Verburg]

Hi Graham,

Very simple patch (just me trying the process out more than anything) to convert a 2 parameter if check into a private method.

Test still passes, didn't check code coverage though (do you have a CI server running somewhere publicly?)

Cheers,

Martijn

[Graham Allan]

Hey Martijn,

The patch is good and will be applied to trunk.

There is a CI server for the project, hosted by CloudBees. It's currently private, and I will look into making it publicly visible. However, I'm not sure it would do much good while still using Subversion (it'll only run and test committed code, which is no use for a patch).

Running 'mvn package' should run tests which cover that code, but like you say, code coverage is useful. Beware if running it locally though, as it sometimes causes spurious failures (trying to analyse bytecode that has been modified to contain extra coverage bytecode gets a bit screwy).

I'll try to document this stuff on the wiki.

Many thanks, 

Graham