Expressing interest in the project

[Subhadip Ghosh]

Hey Graham,

I just came across your blog post. I hope the project is still in active
development and I am not too late. I will check out the code and go
through the rest of your blog. I work as a Java developer in an IT firm.
I will be glad if I am allowed to make a contribution to the project.

--
Warm Regards,
Subhadip

[Mani Sarkar]

Hi Subhadip,

Welcome aboard!

The project is very much active - just a low latency mailing list.

Feel free to go through the issues list on github (https://github.com/MutabilityDetector/MutabilityDetector/issues), there is a handful of tasks to be done,

Any queries please post them here.

Cheers,

Mani

[Graham Allan]

Hey Subhadip,

Mani beat me to it! Yup, definitely not too late. 

First steps are to fork the project on GitHub, and make sure you can build on your machine. Once that's complete, we can talk about which specific issue you want to work on -- there's still several to choose from. If you need any help at all, about anything in this process (git, GitHub, Maven, whatever) then please do ask here. There are no silly questions!

Let us know how it goes.

Kind regards,

Graham

--
You received this message because you are subscribed to the Google Groups "mutability-detector" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mutability-dete...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Subhadip Ghosh]

Hi,

I have checked out the master branch of MutabilityDetector and ClientOfMutabilityDetector. The test cases ran Ok for both. I had to change the below two import statement

import org.mutabilitydetector.repackaged.com.google.classpath.ClassPath;
import org.mutabilitydetector.repackaged.com.google.classpath.ClassPathFactory;

to

import com.google.classpath.ClassPath;
import com.google.classpath.ClassPathFactory;

for CheckSomeClass.java in ClientOfMutabilityDetector. Any idea why?

Also, I am using Eclipse + m2e. The build-helper-maven-plugin is showing a red mark, says "Plugin execution not covered by lifecycle configuration: org.codehaus.mojo:build-helper-maven-plugin:1.7:add-test-source (execution: default, phase: generate-sources)".  Can you help me resolve it please?

Regards,
Subhadip Ghosh

[Graham Allan]

Hi Subhadip,

With the import problem I think I can guess what's going on. Short story: because of how Maven generates Eclipse projects.

Longer story: First some background, the JAR that Mutability Detector is distributed as is what's commonly referred to as an "uberjar". This means the JAR contains the .class files of all its dependencies, rather than relying on them being available on the user's classpath. Since its possible for the classpath to have conflicting classes, we also "repackage" the classes into our own namespace, hence the import of a class from com.google.classpath begins with org.mutabilitydetector.repackaged*. If you were looking to verify this, you could look into the JAR file (with e.g. 7zip, or "unzip -l") and find a class file at the matching directory. 

So why did you have to change the import? My guess is that this is an issue with how Maven (or at least, the eclipse:eclipse command) generates the project files for Eclipse. If it finds one of its dependencies also in the workspace, it will try to depend on it as a "Source Project" within Eclipse, rather than as a normal library dependency (via the Build Path). This means all the compiled classes from Mutability Detector are available on the classpath of ClientOfMutabilityDetector, and this includes the dependencies *before* they've been moved into a different package.  There's a way to test that theory: with the code currently compiling in Eclipse, try to run "mvn compile" for ClientOfMutabilityDetector on the command line. Because the command line doesn't know anything about Eclipse's Source Projects, it should fail to compile, because it doesn't depend directly on the library that provides the com.google.classpath classes. If you switch the imports back to the org.mutabilitydetector.repackaged, it should successfully compile.

When I don't want this behaviour, and I want to depend on it as a normal library, I will run eclipse:eclipse with the -Declipse.useProjectReferences=false flag. I don't know how to do the equivalent with m2e, perhaps it's something like this answer[2] suggests. Could you try that?

Does that explanation make sense? 

With the m2e problem, I'm less sure, because I don't use it and know next to nothing about it. According to this StackOverflow answer[1], the solution is to install the m2e build-helper connector in Eclipse. There is no m2e configuration in the pom.xml so less chance of there being something wrong in there :)

Mani, do you use m2e? Are you able to help?

Hope this answers your first question, and we can maybe get some m2e knowledge from Mani to help with your second question. Please ask any clarifying questions you need to :)

~ Graham

P.S. if you cloned directly from the github.com/MutabilityDetector repositories, you may not be ready to submit Pull Requests, and may have to fork to your own repository and checkout again. It's just the way GitHub works, which is different from what you may be used to with e.g. Subversion. We can get into that later.

[0] Note, we may get rid of this soon.

[1] http://stackoverflow.com/questions/7409823/m2e-lifecycle-mapping-not-found

[2] http://stackoverflow.com/a/12578694/4120

[Mani Sarkar]

Hi guys

I havent been using Windows for a long time and don't use Eclipse as my primary IDE so a bit out of touch with Eclipse and m2e, but from memory I know there is a configuration page in Eclipse for m2e, I also came across these links [1] and [2] that I think clarifies the same question.

Although [2] suggests we could amend our pom.xml to say useProjectReferences=false or useProjectReferences=true depending on which behaviour you would like to facilitate.

If these don't help I'll be happy to investigate this one further for you.

[1] http://stackoverflow.com/questions/10688344/in-eclipse-m2e-how-to-reference-workspace-project

[2] https://gist.github.com/mlandis5am/3989404

Cheers,

Mani

You received this message because you are subscribed to a topic in the Google Groups "mutability-detector" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mutability-detector/2sPycOBqJ8c/unsubscribe.
To unsubscribe from this group and all its topics, send an email to mutability-dete...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

@theNeomatrix369  |  Blog  |  LJC Associate & LJC Advocate (@adoptopenjdk & @adoptajsr programs)

Meet-a-Project - MutabilityDetector  |  Bitbucket  |  Github  |  LinkedIn

Come to Devoxx UK 2014: http://www.devoxx.co.uk/

Don't chase success, rather aim for "Excellence", and success will come chasing after you!

[Mani Sarkar]

Guy

I think I have a solution although if this is what you want then it will work for you:

Ran the below from within the Mutability Detector project is available in my maven repo:

$ mvn clean install

You can run it via Eclipse via the Maven Install option in the popup menu in the Mutability Detector project.

Then I went to the project in Eclipse and changed the below two lines in CheckSomeClass.java:

import org.mutabilitydetector.repackaged.com.google.classpath.ClassPath;

import org.mutabilitydetector.repackaged.com.google.classpath.ClassPathFactory;

to

import org.mutabilitydetector.internal.com.google.classpath.ClassPath;

import org.mutabilitydetector.internal.com.google.classpath.ClassPathFactory;

Finally I inserted the below in the existing <plugins> block in the pom.xml for ClientOfMutabilityDetector

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-eclipse-plugin</artifactId>
    <version>2.9</version>
    <configuration>
            <useProjectReferences>true</useProjectReferences>
    </configuration>
  </plugin>

Then I ran the below on the command prompt, its also possible to specify this via the popup menu (mvn build... goal: eclipse:...):

$ mvn eclipse:clean

followed by 

$ mvn eclipse:eclipse

Refreshed the project (or reopen the project whichever works for you). And the redlines disappear. I have Infinitest running which tells me most of the tests passed, 5 ignored, except 2 odd ones that failed - but when I run 

$ mvn clean test 

none of the tests fail.

@Graham - are you okay we add the <plugin> block to our pom.xml and also change the import reference as the .jar file does not refer to a ...repackeg.com.... rather an ...internal.com... after I looked into the file using unzip.

I'm curious to know what you make of this solution, if it works for you, maybe you can create a pull request with the solution.

Cheers,

Mani

[Graham Allan]

Hey Mani, Subhadip,

That solution sounds good to me. Sabhadip, do you want to try Mani's suggestion, and issue a pull request with the change?

Best regards,

Graham A

[Subhadip Ghosh]

Hey Graham/Mani,

I will try the solution and let you know. Is that okay guys? I have been out of station for past weeks, so I could not try it earlier.

Mani,

I don't use Windows either, at home. Although I would like to know what IDE you use (if at all) for Java. I am comfortable with running Maven from command line just would like to do it from Eclipse also.

Thanks,
Subhadip

Mani

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-detector+unsub...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "mutability-detector" group.

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-detector+unsub...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "mutability-detector" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mutability-detector/2sPycOBqJ8c/unsubscribe.

To unsubscribe from this group and all its topics, send an email to mutability-detector+unsub...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

@theNeomatrix369  |  Blog  |  LJC Associate & LJC Advocate (@adoptopenjdk & @adoptajsr programs)

Meet-a-Project - MutabilityDetector  |  Bitbucket  |  Github  |  LinkedIn

Come to Devoxx UK 2014: http://www.devoxx.co.uk/

Don't chase success, rather aim for "Excellence", and success will come chasing after you!

--

@theNeomatrix369  |  Blog  |  LJC Associate & LJC Advocate (@adoptopenjdk & @adoptajsr programs)

Meet-a-Project - MutabilityDetector  |  Bitbucket  |  Github  |  LinkedIn

Come to Devoxx UK 2014: http://www.devoxx.co.uk/

Don't chase success, rather aim for "Excellence", and success will come chasing after you!

--
You received this message because you are subscribed to the Google Groups "mutability-detector" group.

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-detector+unsub...@googlegroups.com.

[Graham Allan]

Sure, take your time and don't hesitate to seek help.

I tend to use Eclipse for Java, and generate the config files from the command line. There's probably some nice features I'm missing out on by not using the m2e plugin but I get by :-)

~ Graham

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-dete...@googlegroups.com.

[Mani Sarkar]

I use IntelliJ extensively both at home and work but some projects are still in Eclipse (Infinitest works better in Eclipse than in IntelliJ).

I use commandline for almost everything, especially maven and git commands.

To unsubscribe from this group and all its topics, send an email to mutability-dete...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Subhadip Ghosh]

Hey guys,

Probably I am missing something, but I cloned the MutabilityDetector project and ran the mvn test, but one test case is failing. Below is the test result:

<testcase time="0.012" classname="org.mutabilitydetector.WellKnownJavaTypesTest" name="JDK13Services"><failure message=" Expected: com.sun.media.sound.JDK13Services to be NOT_IMMUTABLE      but: com.sun.media.sound.JDK13Services is actually IMMUTABLE     Reasons:     Allowed reasons:         None." type="org.mutabilitydetector.unittesting.MutabilityAssertionError">org.mutabilitydetector.unittesting.MutabilityAssertionError:
Expected: com.sun.media.sound.JDK13Services to be NOT_IMMUTABLE
     but: com.sun.media.sound.JDK13Services is actually IMMUTABLE
    Reasons:
    Allowed reasons:
        None.
    at org.mutabilitydetector.unittesting.internal.AssertionReporter.assertThat(AssertionReporter.java:43)
    at org.mutabilitydetector.unittesting.MutabilityAsserter.assertInstancesOf(MutabilityAsserter.java:109)
    at org.mutabilitydetector.unittesting.MutabilityAssert.assertInstancesOf(MutabilityAssert.java:658)
    at org.mutabilitydetector.WellKnownJavaTypesTest.JDK13Services(WellKnownJavaTypesTest.java:146)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
    at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
    at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:123)
    at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:104)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:164)
    at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:110)
    at org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:175)
    at org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcessWhenForked(SurefireStarter.java:107)
    at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:68)
</failure></testcase>

Can you help me out here a bit please?

Thanks,
Subhadip

Mani

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-detector+unsubscribe...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "mutability-detector" group.

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-detector+unsubscribe...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "mutability-detector" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mutability-detector/2sPycOBqJ8c/unsubscribe.

To unsubscribe from this group and all its topics, send an email to mutability-detector+unsubscribe...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

@theNeomatrix369  |  Blog  |  LJC Associate & LJC Advocate (@adoptopenjdk & @adoptajsr programs)

Meet-a-Project - MutabilityDetector  |  Bitbucket  |  Github  |  LinkedIn

Come to Devoxx UK 2014: http://www.devoxx.co.uk/

Don't chase success, rather aim for "Excellence", and success will come chasing after you!

--

@theNeomatrix369  |  Blog  |  LJC Associate & LJC Advocate (@adoptopenjdk & @adoptajsr programs)

Meet-a-Project - MutabilityDetector  |  Bitbucket  |  Github  |  LinkedIn

Come to Devoxx UK 2014: http://www.devoxx.co.uk/

Don't chase success, rather aim for "Excellence", and success will come chasing after you!

--
You received this message because you are subscribed to the Google Groups "mutability-detector" group.

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-detector+unsubscribe...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Subhadip Ghosh]

Hey Mani,

I believe you meant to add this

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-eclipse-plugin</artifactId>
    <version>2.9</version>
    <configuration>

            <useProjectReferences>false</useProjectReferences>
    </configuration>
  </plugin>

instead of this

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-eclipse-plugin</artifactId>
    <version>2.9</version>
    <configuration>
            <useProjectReferences>true</useProjectReferences>
    </configuration>
  </plugin>

in pom.xml.


Hey Graham/Mani,

I did the following:

1. Changed the import statements in CheckSomeClass.java as advised by Mani.
2. Did not change the pom.xml, instead ran the 'mvn eclipse:eclipse' command with an additional option: -Declipse.useProjectReferences=false

I ran the test cases of ClientOfMutabilityDetector from eclipse m2e and all of the tests ran fine.

Thanks,
Subhadip

Mani

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-detector+unsubscribe...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "mutability-detector" group.

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-detector+unsubscribe...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "mutability-detector" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mutability-detector/2sPycOBqJ8c/unsubscribe.

To unsubscribe from this group and all its topics, send an email to mutability-detector+unsubscribe...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

@theNeomatrix369  |  Blog  |  LJC Associate & LJC Advocate (@adoptopenjdk & @adoptajsr programs)

Meet-a-Project - MutabilityDetector  |  Bitbucket  |  Github  |  LinkedIn

Come to Devoxx UK 2014: http://www.devoxx.co.uk/

Don't chase success, rather aim for "Excellence", and success will come chasing after you!

--

@theNeomatrix369  |  Blog  |  LJC Associate & LJC Advocate (@adoptopenjdk & @adoptajsr programs)

Meet-a-Project - MutabilityDetector  |  Bitbucket  |  Github  |  LinkedIn

Come to Devoxx UK 2014: http://www.devoxx.co.uk/

Don't chase success, rather aim for "Excellence", and success will come chasing after you!

--
You received this message because you are subscribed to the Google Groups "mutability-detector" group.

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-detector+unsubscribe...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Mani Sarkar]

Good work, but it would be great to change the pom as well and add the documentation about mvn eclipse... to the Readme.

Send us a pull request and we should be ready to merge it so that the next dev can smoothly go about using MD in Eclpse.

Cheers,

Mani

To unsubscribe from this group and all its topics, send an email to mutability-dete...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Graham Allan]

The test failure on JDK13Services is interesting. I think the test case is only there because at some point the bytecode of that class caused Mutability Detector to crash. What version of the JDK are you using? That could be the main difference that would cause it to pass for me but fail for you.

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-dete...@googlegroups.com.

[Subhadip Ghosh]

I am using Oracle Java 1.7.0_60.

Thanks,
Subhadip

Mani

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-dete...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "mutability-detector" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mutability-dete...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "mutability-detector" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mutability-detector/2sPycOBqJ8c/unsubscribe.

To unsubscribe from this group and all its topics, send an email to mutability-dete...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

@theNeomatrix369  |  Blog  |  LJC Associate & LJC Advocate (@adoptopenjdk & @adoptajsr programs)

Meet-a-Project - MutabilityDetector  |  Bitbucket  |  Github  |  LinkedIn

Come to Devoxx UK 2014: http://www.devoxx.co.uk/

Don't chase success, rather aim for "Excellence", and success will come chasing after you!

--

@theNeomatrix369  |  Blog  |  LJC Associate & LJC Advocate (@adoptopenjdk & @adoptajsr programs)

Meet-a-Project - MutabilityDetector  |  Bitbucket  |  Github  |  LinkedIn

Come to Devoxx UK 2014: http://www.devoxx.co.uk/

Don't chase success, rather aim for "Excellence", and success will come chasing after you!

--
You received this message because you are subscribed to the Google Groups "mutability-detector" group.

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-dete...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "mutability-detector" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mutability-dete...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "mutability-detector" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mutability-dete...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "mutability-detector" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mutability-detector/2sPycOBqJ8c/unsubscribe.

To unsubscribe from this group and all its topics, send an email to mutability-dete...@googlegroups.com.

[Subhadip Ghosh]

Hi Mani,

One question though. Should we put something which is specific to a particular IDE in the pom.xml? Instead, we can update the CONTRIBUTING.md with the additional command line option for future eclipse users. Please let me know your thoughts.

Thanks,
Subhadip

Mani

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-dete...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

You received this message because you are subscribed to the Google Groups "mutability-detector" group.

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-dete...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "mutability-detector" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mutability-detector/2sPycOBqJ8c/unsubscribe.
To unsubscribe from this group and all its topics, send an email to mutability-dete...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

@theNeomatrix369  |  Blog  |  LJC Associate & LJC Advocate (@adoptopenjdk & @adoptajsr programs)

Meet-a-Project - MutabilityDetector  |  Bitbucket  |  Github  |  LinkedIn

Come to Devoxx UK 2014: http://www.devoxx.co.uk/

Don't chase success, rather aim for "Excellence", and success will come chasing after you!

--

@theNeomatrix369  |  Blog  |  LJC Associate & LJC Advocate (@adoptopenjdk & @adoptajsr programs)

Meet-a-Project - MutabilityDetector  |  Bitbucket  |  Github  |  LinkedIn

Come to Devoxx UK 2014: http://www.devoxx.co.uk/

Don't chase success, rather aim for "Excellence", and success will come chasing after you!

--
You received this message because you are subscribed to the Google Groups "mutability-detector" group.

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-dete...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

You received this message because you are subscribed to the Google Groups "mutability-detector" group.

To unsubscribe from this group and stop receiving emails from it, send an email to mutability-dete...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "mutability-detector" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mutability-detector/2sPycOBqJ8c/unsubscribe.
To unsubscribe from this group and all its topics, send an email to mutability-dete...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Graham Allan]

I'm much less fussy about what goes into the pom for the ClientOfMutabilityDetector project, since it's only to be used for testing. If adding to the pom would have made it "just work", I lean slightly in that direction. I think you're currently the best placed to judge what is easiest for a newcomer, Subhadip, so let's make it the way you would have preferred to see it.

Make sense?

[Graham Allan]

> I am using Oracle Java 1.7.0_60.

I couldn't reproduce with with 1.7.0_21 (that I happened to have lying around) but I did reproduce with 1.8.0_05, so it looks like JDK13Services has changed somewhere in between there. I also noticed a bunch of other issues with JDK 8, so will have to investigate.

Thanks for the extra info!

~ Graham A

P.S. when I reply to emails from this group, it normally only replies to the group. Have you been receiving the other mails that have been sent only to mutability-detector@googlegroups.com ?

[Mani Sarkar]

I'll go with what Graham says - besides you are in the best position to suggest what solves this problem for you and how the next person can avert it.

Looking forward to a pull request or documentation on the wiki or both - whichever floats the boat.

Cheers,

Mani

[Subhadip Ghosh]

I will include that in the POM and send a pull request. Will let you guys know.

Thanks,
Subhadip

[Subhadip Ghosh]

Hey Mani,

Thanks for accepting my pull request. Will you please assign me with a new task in Github related to the project? Also, I don't think any modification is needed in the Contributing.md because after adding the plugin config in POM.xml, normal mvn eclipse:eclipse will do the needed task. However, there is currently a bug with Eclipse m2e plugin (using Kepler + m2e 1.4.0), which may show an error as below:

An internal error occurred during: "Importing Maven projects".
Unsupported IClasspathEntry kind=4

But after doing the below operations, the error goes away.
1. Maven -> Disable Maven Nature
2. Configure -> Convert to Maven project

Not sure if this needed to be added in the Contributing.md.

Thanks,
Subhadip

On 06/29/2014 09:48 AM, Subhadip Ghosh wrote:

Hey Mani,

I have created a pull request for the changes in ClientOfMutabilityDetector. Please review the changes and let me know if there is something which I have done wrong, as this is my first pull request on Github. I will then correct it and send another one if required.

Thanks,
Subhadip

[Mani Sarkar]

Hi Subhadip,

I'm big on documentation to the extent in the short-run it might not look relevant but as we go along bits of documentation like this under known issues, will help the next traveller.

So even trivial steps would help for a newbie, and the issue with Kepler would be great to have under note or known issues with eclipse...etc...

About assigning a task, have look at the github issues (https://github.com/MutabilityDetector/MutabilityDetector/issues) and also go through the archives of messages to get upto speed with the different conversations and possible pending tasks. There's an issues list - one per project under each of the projects in https://github.com/MutabilityDetector/, feel free to pick any of them.

I hope this helps.

Cheers,

Mani