Sending pull requests

[bruienne]

I added some functionality to the Computers and Packages controllers (and related form templates) to allow for batch deletion of items. I pushed my changes to my own fork but I am hesitant to send a pull request because there's a bunch of code changes in there that are the result of me tinkering around to get a feel for how everything hangs together; they're messy but unrelated. I didn't have the foresight to neatly wrap the changes I want to send a pull request for in their own commit, so there'd be a bunch of files you want to ignore for now.

If I send a pull request would it suffice to indicate which files are actually involved in the changes I made? For both packages and computers it should only be 4 in total, their controllers and the form that is called by "Edit Selection".

Thanks,

Pepijn.

[Jordan Raine]

Hey Pepijn,

Can you checkout the current master at jnraine/munkiserver and apply the code changes relevant to the functionality you added, then submit a PR? Since you know the changes best, it may be a safer way to avoid committing something that doesn't need to be there.

-- 

Jordan Raine

--
You received this message because you are subscribed to the Google Groups "munkiserver-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to munkiserver-d...@googlegroups.com.
To post to this group, send email to munkise...@googlegroups.com.
Visit this group at http://groups.google.com/group/munkiserver-dev?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[bruienne]

Jordan, sure thing. I just cloned a fresh copy and will apply my changes to that.

Thanks,

Pepijn.

[bruienne]

I ended up clearing out my messy fork and creating a new one with the current code and committed my changes based on that.

Thanks,

Pepijn.

On Wednesday, May 29, 2013 5:56:34 PM UTC-4, Jordan Raine wrote: