Warranty update issues

[Chris George]

I'm having an issue with my Munkiserver regarding the warranty information. 90% of the time, it seems to work OK, but on a handful of machines (most of which, I think, are the ones I add manually vs. importing from ARD) I get the error "We're sorry, but something went wrong. We've been notified about this issue and we'll take a look at it shortly." However, if I then go back to the warranty tab, it contains what appears to be up-to-date information.

Furthermore, I've been getting the following output in the emailed report from cron:

rake aborted!

wrong number of arguments(1 for 0)

/Volumes/Data/munkiserver/app/views/admin_mailer/warranty_notification.html.erb:28:in `to_s'

/Volumes/Data/munkiserver/app/views/admin_mailer/warranty_notification.html.erb:28:in `_app_views_admin_mailer_warranty_notification_html_erb___297029367061299014_70203680500880'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/action_view/template.rb:145:in `block in render'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/activesupport-3.2.12/lib/active_support/notifications.rb:125:in `instrument'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/action_view/template.rb:143:in `render'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/action_view/renderer/template_renderer.rb:47:in `block (2 levels) in render_template'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/action_view/renderer/abstract_renderer.rb:38:in `block in instrument'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/activesupport-3.2.12/lib/active_support/notifications.rb:123:in `block in instrument'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/activesupport-3.2.12/lib/active_support/notifications/instrumenter.rb:20:in `instrument'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/activesupport-3.2.12/lib/active_support/notifications.rb:123:in `instrument'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/action_view/renderer/abstract_renderer.rb:38:in `instrument'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/action_view/renderer/template_renderer.rb:46:in `block in render_template'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/action_view/renderer/template_renderer.rb:54:in `render_with_layout'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/action_view/renderer/template_renderer.rb:45:in `render_template'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/action_view/renderer/template_renderer.rb:18:in `render'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/action_view/renderer/renderer.rb:36:in `render_template'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/action_view/renderer/renderer.rb:17:in `render'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/abstract_controller/rendering.rb:110:in `_render_template'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/abstract_controller/rendering.rb:103:in `render_to_body'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/abstract_controller/rendering.rb:88:in `render'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionmailer-3.2.12/lib/action_mailer/base.rb:713:in `block in collect_responses_and_parts_order'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionmailer-3.2.12/lib/action_mailer/base.rb:724:in `each'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionmailer-3.2.12/lib/action_mailer/base.rb:724:in `each_template'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionmailer-3.2.12/lib/action_mailer/base.rb:709:in `collect_responses_and_parts_order'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionmailer-3.2.12/lib/action_mailer/base.rb:648:in `mail'

/Volumes/Data/munkiserver/app/mailers/admin_mailer.rb:24:in `warranty_notification'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/abstract_controller/base.rb:167:in `process_action'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/abstract_controller/base.rb:121:in `process'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionpack-3.2.12/lib/abstract_controller/rendering.rb:45:in `process'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionmailer-3.2.12/lib/action_mailer/base.rb:458:in `process'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionmailer-3.2.12/lib/action_mailer/base.rb:452:in `initialize'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionmailer-3.2.12/lib/action_mailer/base.rb:439:in `new'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/actionmailer-3.2.12/lib/action_mailer/base.rb:439:in `method_missing'

/Volumes/Data/munkiserver/app/models/manifest/computer.rb:269:in `deliver_warranty_notification'

/Volumes/Data/munkiserver/app/models/manifest/computer.rb:253:in `update_warranty'

/Volumes/Data/munkiserver/lib/tasks/warranties.rake:6:in `block (3 levels) in <top (required)>'

/Volumes/Data/munkiserver/lib/tasks/warranties.rake:5:in `each'

/Volumes/Data/munkiserver/lib/tasks/warranties.rake:5:in `block (2 levels) in <top (required)>'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/task.rb:246:in `call'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/task.rb:246:in `block in execute'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/task.rb:241:in `each'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/task.rb:241:in `execute'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/task.rb:184:in `block in invoke_with_call_chain'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/task.rb:177:in `invoke_with_call_chain'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/task.rb:170:in `invoke'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/application.rb:143:in `invoke_task'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/application.rb:101:in `block (2 levels) in top_level'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/application.rb:101:in `each'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/application.rb:101:in `block in top_level'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/application.rb:110:in `run_with_threads'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/application.rb:95:in `top_level'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/application.rb:73:in `block in run'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/application.rb:160:in `standard_exception_handling'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/gems/rake-10.0.4/lib/rake/application.rb:70:in `run'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/bin/ruby_noexec_wrapper:14:in `eval'

/Users/admin/.rvm/gems/ruby-1.9.3-p448/bin/ruby_noexec_wrapper:14:in `<main>'

Tasks: TOP => warranties:update_all

(See full trace by running task with --trace) 

Successfully updated tc06-imac-01's warranty.

Successfully updated tc06-imac-02's warranty.

Successfully updated tc06-imac-03's warranty.

Successfully updated tc06-imac-04's warranty.

Successfully updated tc06-imac-05's warranty.

It then lists all the machines it was able to successfully update. If I remove the problematic machines from munkiserver, the cron job completes successfully.

Any ideas?

[Jordan Raine]

Hey Chris,

Thanks for the report! I’ve committed a fix: https://github.com/jnraine/munkiserver/commit/14e8e0ab5044bddac634d5184befd06524650b30

Please let me know if this alleviates the issue. If not, could you send along the error message when you see the “We’re sorry, but something went wrong” message? It should be in the log/production.log or log/development file (depending on your environment).

Jordan

--
You received this message because you are subscribed to the Google Groups "munkiserver-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to munkiserver-d...@googlegroups.com.
To post to this group, send email to munkise...@googlegroups.com.
Visit this group at http://groups.google.com/group/munkiserver-dev.
For more options, visit https://groups.google.com/groups/opt_out.

[Chris George]

I just did a pull, and that seems to have done the trick. I checked both updating individual machines, as well as manually running the rake warranty:update_all, and both seem to have gone without a hitch. I was thinking it was a problem with my install, or I'd have reported it as a bug through github.

Nice response time! Thanks a lot!

--Chris